From: Jean Delvare <jdelvare@suse.de>
To: "Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>
Cc: "Greg Kroah-Hartman" <gregkh@linuxfoundation.org>,
"Lars-Peter Clausen" <lars@metafoo.de>,
"Michael Hennerich" <Michael.Hennerich@analog.com>,
"Jonathan Cameron" <jic23@kernel.org>,
"Hans de Goede" <hdegoede@redhat.com>,
"Mauro Carvalho Chehab" <mchehab@kernel.org>,
"Sakari Ailus" <sakari.ailus@linux.intel.com>,
"Niklas Söderlund" <niklas.soderlund@ragnatech.se>,
"Parthiban Veerasooran" <parthiban.veerasooran@microchip.com>,
"Christian Gromm" <christian.gromm@microchip.com>,
"Jens Frederich" <jfrederich@gmail.com>,
"Jon Nettleton" <jon.nettleton@gmail.com>,
"Andy Shevchenko" <andy.shevchenko@gmail.com>,
"Wolfram Sang" <wsa@kernel.org>,
"Jeremy Kerr" <jk@codeconstruct.com.au>,
"Kalle Valo" <kvalo@kernel.org>,
"Hans Verkuil" <hverkuil-cisco@xs4all.nl>,
"Peter Senna Tschudin" <peter.senna@gmail.com>,
"Steven Rostedt (Google)" <rostedt@goodmis.org>,
"Crt Mori" <cmo@melexis.com>, "Haowen Bai" <baihaowen@meizu.com>,
"Tom Rix" <trix@redhat.com>,
"Adrien Grassein" <adrien.grassein@gmail.com>,
"Marek Behún" <kabel@kernel.org>, "Peter Rosin" <peda@axentia.se>,
"Menna Mahmoud" <eng.mennamahmoud.mm@gmail.com>,
linux-iio@vger.kernel.org, linux-staging@lists.linux.dev,
kernel@pengutronix.de, linux-media@vger.kernel.org
Subject: Re: [PATCH] staging: Switch i2c drivers back to use .probe()
Date: Wed, 24 May 2023 12:25:01 +0200 [thread overview]
Message-ID: <20230524122501.33c46d6f@endymion.delvare> (raw)
In-Reply-To: <20230523200036.465180-1-u.kleine-koenig@pengutronix.de>
On Tue, 23 May 2023 22:00:36 +0200, Uwe Kleine-König wrote:
> After commit b8a1a4cd5a98 ("i2c: Provide a temporary .probe_new()
> call-back type"), all drivers being converted to .probe_new() and then
> 03c835f498b5 ("i2c: Switch .probe() to not take an id parameter") convert
> back to (the new) .probe() to be able to eventually drop .probe_new() from
> struct i2c_driver.
>
> Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
> ---
> Hello,
>
> this patch was generated using coccinelle.
>
> I chose to convert all drivers below drivers/staging in a single
> patch, but if you prefer I can split by driver.
>
> If conflicts arise until this is applied, feel free to just drop the
> files with conflicts from this patch. I'll care about the fallout later
> then.
>
> Also note there is no coordination necessary with the i2c tree. Dropping
> .probe_new() will happen only when all (or most) drivers are converted,
> which will happen after v6.5-rc1 for sure.
>
> Best regards
> Uwe
> drivers/staging/iio/addac/adt7316-i2c.c | 2 +-
> drivers/staging/iio/impedance-analyzer/ad5933.c | 2 +-
> drivers/staging/media/atomisp/i2c/atomisp-gc0310.c | 2 +-
> drivers/staging/media/atomisp/i2c/atomisp-gc2235.c | 2 +-
> drivers/staging/media/atomisp/i2c/atomisp-lm3554.c | 2 +-
> drivers/staging/media/atomisp/i2c/atomisp-mt9m114.c | 2 +-
> drivers/staging/media/atomisp/i2c/atomisp-ov2680.c | 2 +-
> drivers/staging/media/atomisp/i2c/atomisp-ov2722.c | 2 +-
> drivers/staging/media/atomisp/i2c/ov5693/atomisp-ov5693.c | 2 +-
> drivers/staging/media/max96712/max96712.c | 2 +-
> drivers/staging/most/i2c/i2c.c | 2 +-
> drivers/staging/olpc_dcon/olpc_dcon.c | 2 +-
> 12 files changed, 12 insertions(+), 12 deletions(-)
> (...)
Reviewed-by: Jean Delvare <jdelvare@suse.de>
--
Jean Delvare
SUSE L3 Support
prev parent reply other threads:[~2023-05-24 10:25 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-23 20:00 [PATCH] staging: Switch i2c drivers back to use .probe() Uwe Kleine-König
2023-05-23 20:26 ` Jonathan Cameron
2023-05-23 20:40 ` Hans de Goede
2023-05-24 6:01 ` Uwe Kleine-König
2023-05-24 8:44 ` Hans de Goede
2023-05-24 10:25 ` Jean Delvare [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230524122501.33c46d6f@endymion.delvare \
--to=jdelvare@suse.de \
--cc=Michael.Hennerich@analog.com \
--cc=adrien.grassein@gmail.com \
--cc=andy.shevchenko@gmail.com \
--cc=baihaowen@meizu.com \
--cc=christian.gromm@microchip.com \
--cc=cmo@melexis.com \
--cc=eng.mennamahmoud.mm@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=hdegoede@redhat.com \
--cc=hverkuil-cisco@xs4all.nl \
--cc=jfrederich@gmail.com \
--cc=jic23@kernel.org \
--cc=jk@codeconstruct.com.au \
--cc=jon.nettleton@gmail.com \
--cc=kabel@kernel.org \
--cc=kernel@pengutronix.de \
--cc=kvalo@kernel.org \
--cc=lars@metafoo.de \
--cc=linux-iio@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=mchehab@kernel.org \
--cc=niklas.soderlund@ragnatech.se \
--cc=parthiban.veerasooran@microchip.com \
--cc=peda@axentia.se \
--cc=peter.senna@gmail.com \
--cc=rostedt@goodmis.org \
--cc=sakari.ailus@linux.intel.com \
--cc=trix@redhat.com \
--cc=u.kleine-koenig@pengutronix.de \
--cc=wsa@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox