From: Jonathan Cameron <jic23@kernel.org>
To: Sean Nyekjaer <sean@geanix.com>
Cc: Lars-Peter Clausen <lars@metafoo.de>,
stable@vger.kernel.org,
Jonathan Cameron <Jonathan.Cameron@huawei.com>,
linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/2] iio: accel: fxls8962af: errata bug only applicable for FXLS8962AF
Date: Mon, 5 Jun 2023 20:06:13 +0100 [thread overview]
Message-ID: <20230605200613.69830319@jic23-huawei> (raw)
In-Reply-To: <20230605103223.1400980-2-sean@geanix.com>
On Mon, 5 Jun 2023 12:32:22 +0200
Sean Nyekjaer <sean@geanix.com> wrote:
> Remove special errata handling if FXLS8964AF is used.
>
> Fixes: af959b7b96b8 ("iio: accel: fxls8962af: fix errata bug E3 - I2C burst reads")
> Signed-off-by: Sean Nyekjaer <sean@geanix.com>
> Cc: stable@vger.kernel.org
Applied to the fixes-togreg branch of iio.git
Thanks,
Jonathan
> ---
> drivers/iio/accel/fxls8962af-core.c | 5 +++--
> 1 file changed, 3 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/iio/accel/fxls8962af-core.c b/drivers/iio/accel/fxls8962af-core.c
> index bf7949e51e6c..3f27834ef04c 100644
> --- a/drivers/iio/accel/fxls8962af-core.c
> +++ b/drivers/iio/accel/fxls8962af-core.c
> @@ -904,9 +904,10 @@ static int fxls8962af_fifo_transfer(struct fxls8962af_data *data,
> int total_length = samples * sample_length;
> int ret;
>
> - if (i2c_verify_client(dev))
> + if (i2c_verify_client(dev) &&
> + data->chip_info->chip_id == FXLS8962AF_DEVICE_ID)
> /*
> - * Due to errata bug:
> + * Due to errata bug (only applicable on fxls8962af):
> * E3: FIFO burst read operation error using I2C interface
> * We have to avoid burst reads on I2C..
> */
next prev parent reply other threads:[~2023-06-05 19:06 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-05 10:32 [PATCH 1/2] iio: accel: fxls8962af: fixup buffer scan element type Sean Nyekjaer
2023-06-05 10:32 ` [PATCH 2/2] iio: accel: fxls8962af: errata bug only applicable for FXLS8962AF Sean Nyekjaer
2023-06-05 19:06 ` Jonathan Cameron [this message]
2023-06-05 19:04 ` [PATCH 1/2] iio: accel: fxls8962af: fixup buffer scan element type Jonathan Cameron
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230605200613.69830319@jic23-huawei \
--to=jic23@kernel.org \
--cc=Jonathan.Cameron@huawei.com \
--cc=lars@metafoo.de \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=sean@geanix.com \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox