Linux IIO development
 help / color / mirror / Atom feed
From: Maksim Kiselev <bigunclemax@gmail.com>
To: andy.shevchenko@gmail.com
Cc: bigunclemax@gmail.com, linux-iio@vger.kernel.org, jic23@kernel.org
Subject: Re: [PATCH v3 1/3] iio: adc: Add Allwinner D1/T113s/R329/T507 SoCs GPADC
Date: Tue, 13 Jun 2023 10:49:19 +0300	[thread overview]
Message-ID: <20230613074919.3936702-1-bigunclemax@gmail.com> (raw)
In-Reply-To: <ZHzjpydKLQ7U_Qwf@surfacebook>

Hi, Andre

>> +	}
>> +
>> +	if (num_channels > SUN20I_GPADC_MAX_CHANNELS) {
>> +		dev_err(dev, "num of channel children out of range");
>> +		return -EINVAL;
>
>Jonathan, but num_channels comes from the device tree. Why do we need to
>validate the upper limit and not simply use as much as we can?
>
>That's why I think this is not a critical error.

Looks like I missed this. So, if we rely on dtbs_check then I agree that
this check is not needed.


  reply	other threads:[~2023-06-13  7:50 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-06-04 18:53 [PATCH v3 0/3] Add support for Allwinner GPADC on D1/T113s/R329/T507 SoCs Maksim Kiselev
2023-06-04 18:53 ` [PATCH v3 1/3] iio: adc: Add Allwinner D1/T113s/R329/T507 SoCs GPADC Maksim Kiselev
2023-06-04 19:19   ` andy.shevchenko
2023-06-13  7:49     ` Maksim Kiselev [this message]
2023-06-04 18:53 ` [PATCH v3 2/3] dt-bindings: " Maksim Kiselev
2023-06-04 19:29   ` Rob Herring
2023-06-05  6:44   ` Krzysztof Kozlowski
2023-06-04 18:53 ` [PATCH v3 3/3] riscv: dts: allwinner: d1: Add GPADC node Maksim Kiselev

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230613074919.3936702-1-bigunclemax@gmail.com \
    --to=bigunclemax@gmail.com \
    --cc=andy.shevchenko@gmail.com \
    --cc=jic23@kernel.org \
    --cc=linux-iio@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox