From: Jonathan Cameron <jic23@kernel.org>
To: "Nuno Sá" <noname.nuno@gmail.com>
Cc: Markus Burri <markus.burri@mt.com>,
linux-kernel@vger.kernel.org,
Alexandru Tachici <alexandru.tachici@analog.com>,
Lars-Peter Clausen <lars@metafoo.de>,
Michael Hennerich <Michael.Hennerich@analog.com>,
linux-iio@vger.kernel.org
Subject: Re: [PATCH v1] iio: ado: ad7192: Add error check and more debug log
Date: Wed, 14 Jun 2023 08:15:10 +0100 [thread overview]
Message-ID: <20230614081510.63602edd@jic23-huawei> (raw)
In-Reply-To: <0ee291f54c38b9c88c9fd5bac15f7421663c7276.camel@gmail.com>
On Tue, 13 Jun 2023 10:46:30 +0200
Nuno Sá <noname.nuno@gmail.com> wrote:
> On Tue, 2023-06-13 at 10:19 +0200, Nuno Sá wrote:
> > On Tue, 2023-06-13 at 07:42 +0200, Markus Burri wrote:
> > > Print read and expected device ID as debug warning.
> > > Add error check for ad_sd_init() result.
> > >
> > > Signed-off-by: Markus Burri <markus.burri@mt.com>
> > > ---
> >
> > You have unrelated changes but they are easy enough to go in same patch
> > (at least for me). Hence:
> >
>
> Actually, consider my tag valid after fixing the typo you have in the commit
> message...
>
This is also v2... So patch title should reflect that.
(well v3 for next version with the typo fixed)
> > Reviewed-by: Nuno Sa <nuno.sa@analog.com>
> >
> >
>
next prev parent reply other threads:[~2023-06-14 7:15 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-13 5:42 [PATCH v1] iio: ado: ad7192: Add error check and more debug log Markus Burri
2023-06-13 8:19 ` Nuno Sá
2023-06-13 8:46 ` Nuno Sá
2023-06-14 7:15 ` Jonathan Cameron [this message]
-- strict thread matches above, loose matches on Subject: below --
2023-06-12 12:15 Markus Burri
2023-06-12 19:40 ` andy.shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230614081510.63602edd@jic23-huawei \
--to=jic23@kernel.org \
--cc=Michael.Hennerich@analog.com \
--cc=alexandru.tachici@analog.com \
--cc=lars@metafoo.de \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=markus.burri@mt.com \
--cc=noname.nuno@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox