From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5E19AEB64DA for ; Sun, 2 Jul 2023 10:34:21 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229776AbjGBKeU (ORCPT ); Sun, 2 Jul 2023 06:34:20 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50988 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229554AbjGBKeT (ORCPT ); Sun, 2 Jul 2023 06:34:19 -0400 Received: from frasgout.his.huawei.com (frasgout.his.huawei.com [185.176.79.56]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D70A7135; Sun, 2 Jul 2023 03:34:18 -0700 (PDT) Received: from lhrpeml500005.china.huawei.com (unknown [172.18.147.206]) by frasgout.his.huawei.com (SkyGuard) with ESMTP id 4Qv53V1fv4z6J6n8; Sun, 2 Jul 2023 18:32:38 +0800 (CST) Received: from localhost (10.48.51.211) by lhrpeml500005.china.huawei.com (7.191.163.240) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.27; Sun, 2 Jul 2023 11:34:13 +0100 Date: Sun, 2 Jul 2023 18:34:09 +0800 From: Jonathan Cameron To: Waqar Hameed CC: Jonathan Cameron , , "Conor Dooley" , Lars-Peter Clausen , , , Rob Herring , , Krzysztof Kozlowski , Subject: Re: [PATCH 1/2] dt-bindings: iio: proximity: Add bindings for Murata IRS-D200 Message-ID: <20230702183409.0000021f@Huawei.com> In-Reply-To: References: <9487391b0565434761055b39ba04900bd839580a.1686926857.git.waqarh@axis.com> <20230617135532.328dc3c8@jic23-huawei> Organization: Huawei Technologies Research and Development (UK) Ltd. X-Mailer: Claws Mail 4.1.0 (GTK 3.24.33; x86_64-w64-mingw32) MIME-Version: 1.0 Content-Type: text/plain; charset="US-ASCII" Content-Transfer-Encoding: 7bit X-Originating-IP: [10.48.51.211] X-ClientProxiedBy: lhrpeml500002.china.huawei.com (7.191.160.78) To lhrpeml500005.china.huawei.com (7.191.163.240) X-CFilter-Loop: Reflected Precedence: bulk List-ID: X-Mailing-List: linux-iio@vger.kernel.org On Mon, 19 Jun 2023 12:41:06 +0200 Waqar Hameed wrote: > On Sat, Jun 17, 2023 at 13:55 +0100 Jonathan Cameron wrote: > > > On Fri, 16 Jun 2023 17:10:42 +0200 > > Waqar Hameed wrote: > > > >> Murata IRS-D200 is a PIR sensor for human detection. It uses the I2C bus > >> for communication with interrupt support. Add devicetree bindings > >> requiring the compatible string, I2C slave address (reg) and interrupts. > >> > >> Signed-off-by: Waqar Hameed > > > > This device will have some power supplies, so I'd expect those to be both > > listed and marked as required (maybe some are optional?) > > Right, will add that here (and call `devm_regulator_get_enable()` in > driver's probe). > > [...] > > >> +required: > >> + - compatible > >> + - reg > >> + - interrupts > > > > If it is possible to remove interrupts from requires - and hence have > > at least a partly functional driver doing basic reading of the sensor > > then that is usually a good idea. Far too many board designers seem > > to decide that they don't need to wire up interrupt liness > > If it's really hard then don't worry too much. > > I see. It would be possible, but would also require some work. Let's > leave it for now then? Sure - as long as you review the patches when they come in :) Jonathan