From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 43FFCEB64DA for ; Sat, 8 Jul 2023 14:06:14 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229631AbjGHOGN (ORCPT ); Sat, 8 Jul 2023 10:06:13 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:43928 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229458AbjGHOGM (ORCPT ); Sat, 8 Jul 2023 10:06:12 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A9517171F; Sat, 8 Jul 2023 07:06:10 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 2203460C85; Sat, 8 Jul 2023 14:06:10 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 51684C433C8; Sat, 8 Jul 2023 14:05:59 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1688825169; bh=lQQG5C/x03QfBnIDAUBC6OthDK2/PtT0kHEqFxkEQpA=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=sasX7Bz9d693N8HkNqBHBzRGJ4UQeUsSOXKfp5MLJd10jXmaiAh1WF1hyO/GppGQU 72LFLdPkcUy+0YQtt6z8d70yuOSiwZ+HBz46iZ+UeMGgm+026bkMPxrqubOwH7gr1a j3gTGv1T3JcRcO5XVtx4eAQH8/3i7yHkUKxctG3O2Tjxpaz2gQbyX2VHkDMIGdE3tt GDLBWH5OibvZjxWb5D99nl5VHmTkculcQJGMpZwxrV83CyigCBbcgNdj9K8ZVPU2SE cxPgRaodwVry1ZPgEVl3CIppvHkpzDMsPUt87C1kuGRDN8kGB6IuQv6hbYhocHA9CE 6iGWQr4i1yDsg== Date: Sat, 8 Jul 2023 15:05:55 +0100 From: Jonathan Cameron To: Maksim Kiselev Cc: linux-iio@vger.kernel.org, Lars-Peter Clausen , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Chen-Yu Tsai , Jernej Skrabec , Samuel Holland , Paul Walmsley , Palmer Dabbelt , Albert Ou , Philipp Zabel , Cristian Ciocaltea , Andre Przywara , Andy Shevchenko , Cosmin Tanislav , Alexander Sverdlin , ChiYuan Huang , Leonard =?UTF-8?B?R8O2aHJz?= , Haibo Chen , Ramona Bolboaca , Ibrahim Tilki , ChiaEn Wu , William Breathitt Gray , Arnd Bergmann , Hugo Villeneuve , Mike Looijmans , Quentin Schulz , Maxime Ripard , devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-sunxi@lists.linux.dev, linux-kernel@vger.kernel.org, linux-riscv@lists.infradead.org Subject: Re: [PATCH v8 0/4] Add support for Allwinner GPADC on D1/T113s/R329/T507 SoCs Message-ID: <20230708150555.45152996@jic23-huawei> In-Reply-To: <20230619154252.3951913-1-bigunclemax@gmail.com> References: <20230619154252.3951913-1-bigunclemax@gmail.com> X-Mailer: Claws Mail 4.1.1 (GTK 3.24.38; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-iio@vger.kernel.org On Mon, 19 Jun 2023 18:42:23 +0300 Maksim Kiselev wrote: > This series adds support for general purpose ADC (GPADC) on new > Allwinner's SoCs, such as D1, T113s, T507 and R329. The implemented driver > provides basic functionality for getting ADC channels data. Applied 1-3 to the togreg branch of iio.git which will initially be pushed out as testing so that 0-day can see if we missed anything. I'll also be rebasing it on rc1 once available before pushing out as togreg. Thanks, Jonathan > > Change History: > v8: > - Added patch that changes Kconfig description for previous Allwinner GPADC > - Changed Kconfig description for this GPADC driver > - Fixed 'reg' range for gpadc node in 'sunxi-d1s-t113.dtsi' > > v7: > - Fixed typo in DT bindings property > > v6: > - Fixed DT bindings regexp for channel properties > - Dropped checking the max number of channels from the drivers code > (This is redundant as we raly on DT bindings check) > > v5: > - Fixed DT bindings properties for child nodes > > v4: > - Fixed DT bindings warnings > - Used GENMASK to clear the irq register > - Minor formatting fixes > > v3: > - Added DT bindings dual license, fixed property order and example formatting > - Added explanations comments for timeout and mutex > - Dropped unnecessary regmap and used readl/writel instead > - Added error message about getting channel number > - Renamed labels and variables to make them self-explanatory > > v2: > - Added lastch flag to avoid addition work for already selected channel > - Added reset assertion on module remove > - Added dynamic channel allocation and dropped iio_chan_spec arrays > - Changed IIO_CHAN_INFO_SCALE type to FRACTIONAL_LOG2 > - Dropped separate compatible strings and configs for T113s and R329 > - Fixed includes > - Fixed Kconfig description > - Removed duplicate probe error messages > - Used FIELD_PREP for bit setup > > v1: > - Initial version > > Maksim Kiselev (4): > iio: adc: Kconfig change description for Allwinner GPADC > iio: adc: Add Allwinner D1/T113s/R329/T507 SoCs GPADC > dt-bindings: iio: adc: Add Allwinner D1/T113s/R329/T507 SoCs GPADC > riscv: dts: allwinner: d1: Add GPADC node > > .../iio/adc/allwinner,sun20i-d1-gpadc.yaml | 91 ++++++ > .../boot/dts/allwinner/sunxi-d1s-t113.dtsi | 10 + > drivers/iio/adc/Kconfig | 12 +- > drivers/iio/adc/Makefile | 1 + > drivers/iio/adc/sun20i-gpadc-iio.c | 276 ++++++++++++++++++ > 5 files changed, 389 insertions(+), 1 deletion(-) > create mode 100644 Documentation/devicetree/bindings/iio/adc/allwinner,sun20i-d1-gpadc.yaml > create mode 100644 drivers/iio/adc/sun20i-gpadc-iio.c >