From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id C4139EB64DD for ; Sun, 16 Jul 2023 16:11:46 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229544AbjGPQLq (ORCPT ); Sun, 16 Jul 2023 12:11:46 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:51468 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229785AbjGPQLp (ORCPT ); Sun, 16 Jul 2023 12:11:45 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 7C2F31B6; Sun, 16 Jul 2023 09:11:44 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 0ECE060D3E; Sun, 16 Jul 2023 16:11:44 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 42ACCC433C7; Sun, 16 Jul 2023 16:11:38 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1689523903; bh=HWacphPikmgnJGPNvAFWGmB20TdoOVVM6awomSy4Ta0=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=knNOaZ9qd+WUqdFq9dwM5hdG6A+frOIqYpllVHOECE3TfXXPC/x+2sx82LOZNIm7S 0LZhL1w+lh9KBi3xhqI7dbrIm+27WUDmo5Kqv4p463llAezp16NB7ncS9plQV2hnym TQ0VxpSUfAMAS7Pdib7UcwY6eWyuax6oQzEid3KwueBw1hS631/+0OJTqZV6vHPPDD Pu9vkRzGFobMh/Bfpk1PIMVmIzS6FsCw+l4cV7XFYSWXZ1PWb/TAn+awGtFkvNNkY0 GQ2Gq7pf0FHC9d5vaMa6AQUrieIKdqFMj8vrze/ewirh6zMvyP08320I+hC03Gml4U +oAPZoqakzWDg== Date: Sun, 16 Jul 2023 17:11:34 +0100 From: Jonathan Cameron To: George Stark Cc: , , , , , , , , , , , Subject: Re: [PATCH v1 0/3] iio: adc: meson: tune init sequence Message-ID: <20230716171134.43d05c45@jic23-huawei> In-Reply-To: <20230715110654.6035-1-gnstark@sberdevices.ru> References: <20230715110654.6035-1-gnstark@sberdevices.ru> X-Mailer: Claws Mail 4.1.1 (GTK 3.24.38; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-iio@vger.kernel.org On Sat, 15 Jul 2023 14:05:57 +0300 George Stark wrote: > This patch is a part of effort to support meson a1 SoC and make meson saradc driver > independent from vendor boot code initialization in common. > > Information was taken from vendor kernel 5.4, 4.19 and vendor uboot 2019. > Most of the bits are undocumented at all or it's not said how they affect measuring. > > All those bits are already initialized in bl* code and since kernel driver dosn't > rewrite or reset any registers but only changes some bits at init stage everything > works fine. > > Test procedure is rather simple - one can change those bits in runtime > (e.g. using devmem) and try to read channels (cat /sys/bus/platform/drivers/meson-saradc/.../iio:device0/*) > changing some of those bits leads to measure procedure errors or abnormal results. > Another test is build meson saradc as module, reset adc by reset bit, reload module > and compare measure results to those got before reset. > > George Stark (3): > iio: adc: meson: init channels 0,1 input muxes > iio: adc: meson: init internal continuous ring counter > iio: adc: meson: init voltage control bits > > drivers/iio/adc/meson_saradc.c | 73 ++++++++++++++++++++++++++++++++++ > 1 file changed, 73 insertions(+) > These look fine to me, but I'd like them to sit on list a little while on off chance anyone else has feedback on them. Thanks, Jonathan