From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 655AFC001DE for ; Sun, 23 Jul 2023 12:50:43 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229551AbjGWMum (ORCPT ); Sun, 23 Jul 2023 08:50:42 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:52170 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229477AbjGWMul (ORCPT ); Sun, 23 Jul 2023 08:50:41 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 09CF812F; Sun, 23 Jul 2023 05:50:41 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 7A90160CF6; Sun, 23 Jul 2023 12:50:40 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id CFA5CC433C7; Sun, 23 Jul 2023 12:50:37 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1690116639; bh=slbfSmpx3IbDjMXZZqOFmJps+X0tVPlAVxM60XEIe7g=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=R9w/e/BO54Ffh5gG/eFUqUM8A3DV4pCGl2pfsUzvLBIU5/l2LLdJTyY4OPYA34IWC sMuVo/0FT72fdZgu2j7BMThorJshbtV7C1AWWZVEKF3QFqcH/Pb5fGLVXABu4xiCCv pmcZuIJ7tYC5FM3uXzkk7rtjPvfBDWCRXYieUZWgRa45KAXy1zOd7a8KItWON7ta2S aWHucmuZyoYujZAFROiZOi1omX+zPfFhmEjQrvsJPddR5UO1FDtD4se7C2yIBSwZKq N0qtS15oWYPQereDyogvCiZMFnoE8tJdF+1LnDHn+fR6sWYgEZwh3zlCW1egGv0eG2 20ULQ2roz6pJg== Date: Sun, 23 Jul 2023 13:50:35 +0100 From: Jonathan Cameron To: Lorenzo Bianconi Cc: Alejandro Tafalla , Lars-Peter Clausen , Jonathan Cameron , linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v3] iio: imu: lsm6dsx: Fix mount matrix retrieval Message-ID: <20230723135035.4a2f0909@jic23-huawei> In-Reply-To: References: <20230714153132.27265-1-atafalla@dnyon.com> <20230715183515.56deaa1d@jic23-huawei> <3017278.mvXUDI8C0e@alexpc> <20230720194037.60d109d7@jic23-huawei> X-Mailer: Claws Mail 4.1.1 (GTK 3.24.38; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-iio@vger.kernel.org On Thu, 20 Jul 2023 23:27:53 +0200 Lorenzo Bianconi wrote: > On Jul 20, Jonathan Cameron wrote: > > Alejandro Tafalla wrote: > > =20 > > > On s=C3=A1bado, 15 de julio de 2023 19:35:15 (CEST) Jonathan Cameron = wrote: =20 > > > > On Fri, 14 Jul 2023 17:31:26 +0200 > > > >=20 > > > > Alejandro Tafalla wrote: =20 > > > > > The function lsm6dsx_get_acpi_mount_matrix should return an error= when > > > > > ACPI > > > > > support is not enabled to allow executing iio_read_mount_matrix i= n the > > > > > probe function. > > > > >=20 > > > > > Fixes: dc3d25f22b88 ("iio: imu: lsm6dsx: Add ACPI mount matrix re= trieval") =20 > > > >=20 > > > > I can fix it up whilst applying if no other issues, but there must = not be > > > > a blank line here. All tags need to be in a single block for some = tooling > > > > that is used with the kernel tree (and some of the checking scripts= warn > > > > about this so it won't get applied with the blank line here). =20 > > >=20 > > > Okay, i'll keep it in mind for new patches. Thank you. =20 > > Np. > >=20 > > Just waiting for Lorenzo to have time to take a final look. =20 >=20 > I am fine with this patch. >=20 > Acked-by: Lorenzo Bianconi >=20 Ah. My filters broke so I'd lost this. Thankfully b4 picked it up and made me go look for where the missing emails had gone. All recovered now and the ack picked up. Thanks, Jonathan > >=20 > > Jonathan > > =20 > > > > =20 > > > > > Signed-off-by: Alejandro Tafalla > > > > > --- > > > > > Changes in v3: > > > > > - Removed unneeded check for err =3D=3D -EOPNOTSUPP. > > > > >=20 > > > > > Changes in v2: > > > > > - Use of error codes instead of true/false > > > > >=20 > > > > > drivers/iio/imu/st_lsm6dsx/st_lsm6dsx_core.c | 2 +- > > > > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > >=20 > > > > > diff --git a/drivers/iio/imu/st_lsm6dsx/st_lsm6dsx_core.c > > > > > b/drivers/iio/imu/st_lsm6dsx/st_lsm6dsx_core.c index > > > > > 6a18b363cf73..b6e6b1df8a61 100644 > > > > > --- a/drivers/iio/imu/st_lsm6dsx/st_lsm6dsx_core.c > > > > > +++ b/drivers/iio/imu/st_lsm6dsx/st_lsm6dsx_core.c > > > > > @@ -2687,7 +2687,7 @@ static int lsm6dsx_get_acpi_mount_matrix(st= ruct > > > > > device *dev,>=20 > > > > > static int lsm6dsx_get_acpi_mount_matrix(struct device *dev, > > > > > =20 > > > > > struct =20 > > > iio_mount_matrix *orientation) =20 > > > > > =20 > > > > > { > > > > >=20 > > > > > - return false; > > > > > + return -EOPNOTSUPP; > > > > >=20 > > > > > } > > > > > =20 > > > > > #endif =20 > > >=20 > > >=20 > > >=20 > > > =20 > > =20