From: Jonathan Cameron <jic23@kernel.org>
To: Biju Das <biju.das.jz@bp.renesas.com>
Cc: Peter Rosin <peda@axentia.se>,
Lars-Peter Clausen <lars@metafoo.de>,
linux-iio@vger.kernel.org,
Geert Uytterhoeven <geert+renesas@glider.be>,
linux-renesas-soc@vger.kernel.org
Subject: Re: [PATCH v3] iio: potentiometer: mcp4018: Use i2c_get_match_data()
Date: Sat, 29 Jul 2023 15:55:14 +0100 [thread overview]
Message-ID: <20230729155514.5eb8bde6@jic23-huawei> (raw)
In-Reply-To: <20230723105209.175545-1-biju.das.jz@bp.renesas.com>
On Sun, 23 Jul 2023 11:52:09 +0100
Biju Das <biju.das.jz@bp.renesas.com> wrote:
> Replace of_device_get_match_data() and i2c_match_id() by i2c_get_match
> _data() by making similar I2C and DT-based matching table.
>
> Signed-off-by: Biju Das <biju.das.jz@bp.renesas.com>
Applied to the togreg branch of iio.git and pushed out as testing for 0-day
to poke at it and see if we missed anything.
Thanks,
Jonathan
> ---
> v2->v3:
> * Added .name field to MCP4018_ID_TABLE macro
> * Replaced MCP4018_ID_TABLE(name, cfg)->MCP4018_ID_TABLE(_name, cfg)
> v1->v2:
> * Added similar I2C and DT-based matching table.
> * Fixed typo i2c_get_match_data(dev)->i2c_get_match_data(client).
> * Dropped error check as all tables have data pointers.
>
> Note:
> This patch is only compile tested.
> ---
> drivers/iio/potentiometer/mcp4018.c | 35 ++++++++++++++++-------------
> 1 file changed, 19 insertions(+), 16 deletions(-)
>
> diff --git a/drivers/iio/potentiometer/mcp4018.c b/drivers/iio/potentiometer/mcp4018.c
> index 89daecc90305..44678d372126 100644
> --- a/drivers/iio/potentiometer/mcp4018.c
> +++ b/drivers/iio/potentiometer/mcp4018.c
> @@ -99,20 +99,25 @@ static const struct iio_info mcp4018_info = {
> .write_raw = mcp4018_write_raw,
> };
>
> +#define MCP4018_ID_TABLE(_name, cfg) { \
> + .name = _name, \
> + .driver_data = (kernel_ulong_t)&mcp4018_cfg[cfg], \
> +}
> +
> static const struct i2c_device_id mcp4018_id[] = {
> - { "mcp4017-502", MCP4018_502 },
> - { "mcp4017-103", MCP4018_103 },
> - { "mcp4017-503", MCP4018_503 },
> - { "mcp4017-104", MCP4018_104 },
> - { "mcp4018-502", MCP4018_502 },
> - { "mcp4018-103", MCP4018_103 },
> - { "mcp4018-503", MCP4018_503 },
> - { "mcp4018-104", MCP4018_104 },
> - { "mcp4019-502", MCP4018_502 },
> - { "mcp4019-103", MCP4018_103 },
> - { "mcp4019-503", MCP4018_503 },
> - { "mcp4019-104", MCP4018_104 },
> - {}
> + MCP4018_ID_TABLE("mcp4017-502", MCP4018_502),
> + MCP4018_ID_TABLE("mcp4017-103", MCP4018_103),
> + MCP4018_ID_TABLE("mcp4017-503", MCP4018_503),
> + MCP4018_ID_TABLE("mcp4017-104", MCP4018_104),
> + MCP4018_ID_TABLE("mcp4018-502", MCP4018_502),
> + MCP4018_ID_TABLE("mcp4018-103", MCP4018_103),
> + MCP4018_ID_TABLE("mcp4018-503", MCP4018_503),
> + MCP4018_ID_TABLE("mcp4018-104", MCP4018_104),
> + MCP4018_ID_TABLE("mcp4019-502", MCP4018_502),
> + MCP4018_ID_TABLE("mcp4019-103", MCP4018_103),
> + MCP4018_ID_TABLE("mcp4019-503", MCP4018_503),
> + MCP4018_ID_TABLE("mcp4019-104", MCP4018_104),
> + { /* sentinel */ }
> };
> MODULE_DEVICE_TABLE(i2c, mcp4018_id);
>
> @@ -157,9 +162,7 @@ static int mcp4018_probe(struct i2c_client *client)
> i2c_set_clientdata(client, indio_dev);
> data->client = client;
>
> - data->cfg = device_get_match_data(dev);
> - if (!data->cfg)
> - data->cfg = &mcp4018_cfg[i2c_match_id(mcp4018_id, client)->driver_data];
> + data->cfg = i2c_get_match_data(client);
>
> indio_dev->info = &mcp4018_info;
> indio_dev->channels = &mcp4018_channel;
prev parent reply other threads:[~2023-07-29 14:55 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-23 10:52 [PATCH v3] iio: potentiometer: mcp4018: Use i2c_get_match_data() Biju Das
2023-07-29 14:55 ` Jonathan Cameron [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230729155514.5eb8bde6@jic23-huawei \
--to=jic23@kernel.org \
--cc=biju.das.jz@bp.renesas.com \
--cc=geert+renesas@glider.be \
--cc=lars@metafoo.de \
--cc=linux-iio@vger.kernel.org \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=peda@axentia.se \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox