From: Jonathan Cameron <jic23@kernel.org>
To: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Cc: "Biju Das" <biju.das.jz@bp.renesas.com>,
"Lars-Peter Clausen" <lars@metafoo.de>,
"Linus Walleij" <linus.walleij@linaro.org>,
"Jakob Hauser" <jahau@rocketmail.com>,
"Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>,
linux-iio@vger.kernel.org,
"Geert Uytterhoeven" <geert+renesas@glider.be>,
linux-renesas-soc@vger.kernel.org
Subject: Re: [PATCH v2 2/2] iio: magnetometer: yamaha-yas530: Drop enum chip_ids
Date: Mon, 28 Aug 2023 14:08:01 +0100 [thread overview]
Message-ID: <20230828140801.1a60e547@jic23-huawei> (raw)
In-Reply-To: <ZNsgFG2aL78IKbYq@smile.fi.intel.com>
On Tue, 15 Aug 2023 09:49:56 +0300
Andy Shevchenko <andriy.shevchenko@linux.intel.com> wrote:
> On Sat, Aug 12, 2023 at 07:57:41AM +0100, Biju Das wrote:
> > Drop the unnecessary enum chip_ids by splitting the array
> > yas5xx_chip_info_tbl[] as individual variables.
>
> In my opinion this is an unneeded churn.
> I leave this to Jonathan to decide.
>
Agree with Andy.
I don't care strongly about doing it one way or another. But as
it's already done via an array - better to leave it like that
and avoid the churn.
Jonathan
prev parent reply other threads:[~2023-08-28 13:08 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-12 6:57 [PATCH v2 0/2] Use i2c_get_match_data() for yamaha-yas530 Biju Das
2023-08-12 6:57 ` [PATCH v2 1/2] iio: magnetometer: yamaha-yas530: Use i2c_get_match_data() Biju Das
2023-08-15 6:50 ` Andy Shevchenko
2023-08-28 13:09 ` Jonathan Cameron
2023-08-12 6:57 ` [PATCH v2 2/2] iio: magnetometer: yamaha-yas530: Drop enum chip_ids Biju Das
2023-08-15 6:49 ` Andy Shevchenko
2023-08-28 13:08 ` Jonathan Cameron [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230828140801.1a60e547@jic23-huawei \
--to=jic23@kernel.org \
--cc=andriy.shevchenko@linux.intel.com \
--cc=biju.das.jz@bp.renesas.com \
--cc=geert+renesas@glider.be \
--cc=jahau@rocketmail.com \
--cc=lars@metafoo.de \
--cc=linus.walleij@linaro.org \
--cc=linux-iio@vger.kernel.org \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=u.kleine-koenig@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox