From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0703BC83F11 for ; Mon, 28 Aug 2023 16:40:27 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230298AbjH1Qj5 (ORCPT ); Mon, 28 Aug 2023 12:39:57 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50434 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230457AbjH1QjY (ORCPT ); Mon, 28 Aug 2023 12:39:24 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C6EC6F9; Mon, 28 Aug 2023 09:39:21 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 6528E63869; Mon, 28 Aug 2023 16:39:21 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 18CD3C433C7; Mon, 28 Aug 2023 16:39:18 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1693240760; bh=5LJ1v2A62rI8z41UV5q4orZmdPInisKLh5rGtam6KFU=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=PgxcobcyCv7ZK1SQHtWPiRZbcyAgyhnB2FASMfMBvMjcxjKGbDrNiBvQOZZ/2/5pS JqaDEG0zEa22adNre6ZfMfS71pRFS9+ggJUG46LDtCMqIZn7ZatDf5OOop2IDuZDq0 XfhCFzzq/y3fAzNVHSU89iFXtNCQmglYMRThppcSCwzwmlweTqVYvQZxT4KVU5O0dK WaXfnOKabvmmPbCiEqlrItpjXPWZZnGQK9XrlF+vozz3ezV3o6zXmbQ6g6hqkJqb+0 YeJ0UJIJIhogmT6HjB1a1GE4gvZKAyeFICnAkv8ssYzwWD6P1SzIf2+uPDqFkIKcey IThvKg15pieJQ== Date: Mon, 28 Aug 2023 17:39:41 +0100 From: Jonathan Cameron To: Yue Haibing Cc: , , , Subject: Re: [PATCH -next] iio: Remove unused declarations Message-ID: <20230828173941.6c2cf470@jic23-huawei> In-Reply-To: <20230811095701.35372-1-yuehaibing@huawei.com> References: <20230811095701.35372-1-yuehaibing@huawei.com> X-Mailer: Claws Mail 4.1.1 (GTK 3.24.38; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-iio@vger.kernel.org On Fri, 11 Aug 2023 17:57:01 +0800 Yue Haibing wrote: > Commit 0f3a8c3f34f7 ("iio: Add support for creating IIO devices via configfs") > declared but never implemented iio_sw_device_type_configfs_{un}register(). > Commit b662f809d410 ("iio: core: Introduce IIO software triggers") declared but > never implemented iio_sw_trigger_type_configfs_{un}register(). > Commit a3e0b51884ee ("iio: accel: add support for FXLS8962AF/FXLS8964AF accelerometers") > declared but never implemented fxls8962af_core_remove(). > Commit 8dedcc3eee3a ("iio: core: centralize ioctl() calls to the main chardev") > declared but never implemented iio_device_ioctl(). > > Commit d430f3c36ca6 ("iio: imu: inv_mpu6050: Use regmap instead of i2c specific functions") > removed inv_mpu6050_write_reg() but not its declaration. > > Signed-off-by: Yue Haibing Applied to the togreg branch of iio.git but I won't push these out (other than as testing) until I can rebase on rc1. Thanks, Jonathan > --- > drivers/iio/accel/fxls8962af.h | 1 - > drivers/iio/iio_core.h | 3 --- > drivers/iio/imu/inv_mpu6050/inv_mpu_iio.h | 1 - > include/linux/iio/sw_device.h | 3 --- > include/linux/iio/sw_trigger.h | 3 --- > 5 files changed, 11 deletions(-) > > diff --git a/drivers/iio/accel/fxls8962af.h b/drivers/iio/accel/fxls8962af.h > index 9cbe98c3ba9a..6eaa2803b26f 100644 > --- a/drivers/iio/accel/fxls8962af.h > +++ b/drivers/iio/accel/fxls8962af.h > @@ -14,7 +14,6 @@ enum { > }; > > int fxls8962af_core_probe(struct device *dev, struct regmap *regmap, int irq); > -int fxls8962af_core_remove(struct device *dev); > > extern const struct dev_pm_ops fxls8962af_pm_ops; > extern const struct regmap_config fxls8962af_i2c_regmap_conf; > diff --git a/drivers/iio/iio_core.h b/drivers/iio/iio_core.h > index 501e286702ef..1a38b1915e7a 100644 > --- a/drivers/iio/iio_core.h > +++ b/drivers/iio/iio_core.h > @@ -30,9 +30,6 @@ struct iio_ioctl_handler { > unsigned int cmd, unsigned long arg); > }; > > -long iio_device_ioctl(struct iio_dev *indio_dev, struct file *filp, > - unsigned int cmd, unsigned long arg); > - > void iio_device_ioctl_handler_register(struct iio_dev *indio_dev, > struct iio_ioctl_handler *h); > void iio_device_ioctl_handler_unregister(struct iio_ioctl_handler *h); > diff --git a/drivers/iio/imu/inv_mpu6050/inv_mpu_iio.h b/drivers/iio/imu/inv_mpu6050/inv_mpu_iio.h > index ed5a96e78df0..95f548235de7 100644 > --- a/drivers/iio/imu/inv_mpu6050/inv_mpu_iio.h > +++ b/drivers/iio/imu/inv_mpu6050/inv_mpu_iio.h > @@ -464,7 +464,6 @@ int inv_mpu6050_probe_trigger(struct iio_dev *indio_dev, int irq_type); > int inv_mpu6050_prepare_fifo(struct inv_mpu6050_state *st, bool enable); > int inv_mpu6050_switch_engine(struct inv_mpu6050_state *st, bool en, > unsigned int mask); > -int inv_mpu6050_write_reg(struct inv_mpu6050_state *st, int reg, u8 val); > int inv_mpu_acpi_create_mux_client(struct i2c_client *client); > void inv_mpu_acpi_delete_mux_client(struct i2c_client *client); > int inv_mpu_core_probe(struct regmap *regmap, int irq, const char *name, > diff --git a/include/linux/iio/sw_device.h b/include/linux/iio/sw_device.h > index eff1e6b2595c..0f7fe7b522e3 100644 > --- a/include/linux/iio/sw_device.h > +++ b/include/linux/iio/sw_device.h > @@ -51,9 +51,6 @@ void iio_unregister_sw_device_type(struct iio_sw_device_type *dt); > struct iio_sw_device *iio_sw_device_create(const char *, const char *); > void iio_sw_device_destroy(struct iio_sw_device *); > > -int iio_sw_device_type_configfs_register(struct iio_sw_device_type *dt); > -void iio_sw_device_type_configfs_unregister(struct iio_sw_device_type *dt); > - > static inline > void iio_swd_group_init_type_name(struct iio_sw_device *d, > const char *name, > diff --git a/include/linux/iio/sw_trigger.h b/include/linux/iio/sw_trigger.h > index 47de2443e984..bc77f88df303 100644 > --- a/include/linux/iio/sw_trigger.h > +++ b/include/linux/iio/sw_trigger.h > @@ -51,9 +51,6 @@ void iio_unregister_sw_trigger_type(struct iio_sw_trigger_type *tt); > struct iio_sw_trigger *iio_sw_trigger_create(const char *, const char *); > void iio_sw_trigger_destroy(struct iio_sw_trigger *); > > -int iio_sw_trigger_type_configfs_register(struct iio_sw_trigger_type *tt); > -void iio_sw_trigger_type_configfs_unregister(struct iio_sw_trigger_type *tt); > - > static inline > void iio_swt_group_init_type_name(struct iio_sw_trigger *t, > const char *name,