From: Jonathan Cameron <jic23@kernel.org>
To: Dmitry Rokosov <ddrokosov@sberdevices.ru>
Cc: Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
Jonathan Cameron <Jonathan.Cameron@huawei.com>,
<linux-iio@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
Lars-Peter Clausen <lars@metafoo.de>
Subject: Re: [PATCH v1 1/1] iio: accel: msa311: Use correct header(s) instead of string_helpers.h
Date: Mon, 28 Aug 2023 18:36:30 +0100 [thread overview]
Message-ID: <20230828183630.54b3fb35@jic23-huawei> (raw)
In-Reply-To: <20230809064723.24jgjgr7pclzz5yo@CAB-WSD-L081021>
On Wed, 9 Aug 2023 09:47:23 +0300
Dmitry Rokosov <ddrokosov@sberdevices.ru> wrote:
> Hello Andy,
>
> Thank you for the patch!
>
> On Tue, Aug 08, 2023 at 07:41:52PM +0300, Andy Shevchenko wrote:
> > There is nothing from string_helpers.h used in the driver, correct
> > the header inclusion block accordingly.
> >
> > Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
>
> Reviewed-by: Dmitry Rokosov <ddrokosov@sberdevices.ru>
>
Applied
Thanks,
J
> > ---
> > drivers/iio/accel/msa311.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/iio/accel/msa311.c b/drivers/iio/accel/msa311.c
> > index 6ddcc3c2f840..b8ddbfd98f11 100644
> > --- a/drivers/iio/accel/msa311.c
> > +++ b/drivers/iio/accel/msa311.c
> > @@ -33,7 +33,7 @@
> > #include <linux/pm.h>
> > #include <linux/pm_runtime.h>
> > #include <linux/regmap.h>
> > -#include <linux/string_helpers.h>
> > +#include <linux/string_choices.h>
> > #include <linux/units.h>
> >
> > #include <linux/iio/buffer.h>
> > --
> > 2.40.0.1.gaa8946217a0b
> >
>
prev parent reply other threads:[~2023-08-28 17:37 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-08 16:41 [PATCH v1 1/1] iio: accel: msa311: Use correct header(s) instead of string_helpers.h Andy Shevchenko
2023-08-09 6:47 ` Dmitry Rokosov
2023-08-28 17:36 ` Jonathan Cameron [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230828183630.54b3fb35@jic23-huawei \
--to=jic23@kernel.org \
--cc=Jonathan.Cameron@huawei.com \
--cc=andriy.shevchenko@linux.intel.com \
--cc=ddrokosov@sberdevices.ru \
--cc=lars@metafoo.de \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox