Re: [RFC PATCH 0/3] Add converter framework

[Jonathan Cameron <Jonathan.Cameron@Huawei.com>]

On Thu, 31 Aug 2023 10:20:20 +0200
Nuno Sá <noname.nuno@gmail.com> wrote:

> On Wed, 2023-08-30 at 17:29 +0100, Jonathan Cameron wrote:
> > On Fri, 4 Aug 2023 16:53:38 +0200
> > Nuno Sa <nuno.sa@analog.com> wrote:
> >   
> > > This is the initial RFC following the discussion in [1]. I'm aware this is
> > > by no means ready for inclusion and it's not even compilable since in
> > > the RFC I did not included the patch to add component_compare_fwnode()
> > > and component_release_fwnode().   
> > 
> > Whilst I haven't read this through yet, I suspect Olivier will be able to
> > offer some insight on some of this and likewise you may be able to
> > point out pitfalls etc in his series (I see you did some review already :)
> > 
> > https://lore.kernel.org/linux-iio/20230727150324.1157933-1-olivier.moysan@foss.st.com/
> > 
> > Both are about multiple interacting components of an overall datapath.
> > Whether there is commonality isn't yet clear to me.
> >   
> 
> I made a very general comment in that series but I need to look better at it. Not
> sure if we can merge them together but let's see...

Great. I wasn't sure either!  If nothing else more cross review is always
good even if we decide we need two frameworks.

My one takeaway from looking at this is I need to understand the component
framework better and do some messing around with simple cases before I'll
be confident on how this works.  Maybe we can get some input from developers
of that framework on future versions?

Jonathan