From: Mighty <bavishimithil@gmail.com>
To: linus.walleij@linaro.org
Cc: bavishimithil@gmail.com, jic23@kernel.org, lars@metafoo.de,
liambeguin@gmail.com, linux-iio@vger.kernel.org, peda@axentia.se,
stable@vger.kernel.org
Subject: Re: [PATCH] iio: afe: rescale: Fix logic bug
Date: Sun, 3 Sep 2023 22:40:56 +0530 [thread overview]
Message-ID: <20230903171056.41-1-bavishimithil@gmail.com> (raw)
In-Reply-To: <CACRpkdYtXAWDcAMRJxh5YbNKmrYurH=z0pR47bftc+u1Yt4Nig@mail.gmail.com>
On Thu, Aug 24, 2023 at 1:54 PM Linus Walleij <linus.walleij@linaro.org> wrote:
> Seems reasonable to me!
I'd say I send a patch to the mailing list and see the response, I'm not very experienced with this device. The inputs of other people who worked on this driver would guide me in the right way then i guess.
> That looks like the channel is actually processed, not raw, right?
> i.e. that should only be done on channels marked as processed.
Yeah the raw channel function does call a correction function in some cases, not very sure why. https://github.com/torvalds/linux/blob/master/drivers/iio/adc/twl6030-gpadc.c#L480
In the end the processed function also calls the raw function again dont know why, https://github.com/torvalds/linux/blob/master/drivers/iio/adc/twl6030-gpadc.c#L496. But in any case there is no mention of the scale attribute, so to make it comply with the condition I dont see an issue adding it to the properties
Regards,
Mithil
next prev parent reply other threads:[~2023-09-03 17:12 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-24 7:54 [PATCH] iio: afe: rescale: Fix logic bug Linus Walleij
2022-05-25 14:08 ` Peter Rosin
2022-05-26 1:29 ` Liam Beguin
2022-05-28 17:01 ` Jonathan Cameron
2023-08-09 13:43 ` Mighty
2023-08-10 8:56 ` Linus Walleij
2023-08-21 16:45 ` Mighty
2023-08-23 8:21 ` Linus Walleij
2023-08-24 7:39 ` Mighty
2023-08-24 8:24 ` Linus Walleij
2023-08-24 8:28 ` Linus Walleij
2023-08-28 18:18 ` Jonathan Cameron
2023-08-29 7:17 ` Linus Walleij
2023-08-29 11:37 ` Jonathan Cameron
2023-09-03 17:10 ` Mighty [this message]
2023-09-04 7:20 ` Linus Walleij
2023-09-03 18:04 ` Mighty
2023-09-04 7:25 ` Linus Walleij
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230903171056.41-1-bavishimithil@gmail.com \
--to=bavishimithil@gmail.com \
--cc=jic23@kernel.org \
--cc=lars@metafoo.de \
--cc=liambeguin@gmail.com \
--cc=linus.walleij@linaro.org \
--cc=linux-iio@vger.kernel.org \
--cc=peda@axentia.se \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).