Linux IIO development
 help / color / mirror / Atom feed
From: Jonathan Cameron <jic23@kernel.org>
To: Biju Das <biju.das.jz@bp.renesas.com>
Cc: "Lars-Peter Clausen" <lars@metafoo.de>,
	"Andy Shevchenko" <andriy.shevchenko@linux.intel.com>,
	"Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>,
	linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org,
	"Biju Das" <biju.das.au@gmail.com>
Subject: Re: [PATCH V2 RESEND] iio: pressure: ms5637: Use i2c_get_match_data()
Date: Sun, 10 Sep 2023 14:43:05 +0100	[thread overview]
Message-ID: <20230910144305.17d7df5d@jic23-huawei> (raw)
In-Reply-To: <20230903145926.66855-1-biju.das.jz@bp.renesas.com>

On Sun,  3 Sep 2023 15:59:26 +0100
Biju Das <biju.das.jz@bp.renesas.com> wrote:

> Simplify probe() by replacing id lookup for retrieving match data and
> device_get_match_data() by i2c_get_match_data().
> 
> Signed-off-by: Biju Das <biju.das.jz@bp.renesas.com>
> Reviewed-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> ---
> v1->v2:
>  * Added Rb tag from Andy
>  * Dropped id variable removal from commit description.
Applied. Thanks,

> ---
>  drivers/iio/pressure/ms5637.c | 6 +-----
>  1 file changed, 1 insertion(+), 5 deletions(-)
> 
> diff --git a/drivers/iio/pressure/ms5637.c b/drivers/iio/pressure/ms5637.c
> index 9b3abffb724b..ac30d76285d1 100644
> --- a/drivers/iio/pressure/ms5637.c
> +++ b/drivers/iio/pressure/ms5637.c
> @@ -144,7 +144,6 @@ static const struct iio_info ms5637_info = {
>  
>  static int ms5637_probe(struct i2c_client *client)
>  {
> -	const struct i2c_device_id *id = i2c_client_get_device_id(client);
>  	const struct ms_tp_data *data;
>  	struct ms_tp_dev *dev_data;
>  	struct iio_dev *indio_dev;
> @@ -159,10 +158,7 @@ static int ms5637_probe(struct i2c_client *client)
>  		return -EOPNOTSUPP;
>  	}
>  
> -	if (id)
> -		data = (const struct ms_tp_data *)id->driver_data;
> -	else
> -		data = device_get_match_data(&client->dev);
> +	data = i2c_get_match_data(client);
>  	if (!data)
>  		return -EINVAL;
>  


      reply	other threads:[~2023-09-10 13:43 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-09-03 14:59 [PATCH V2 RESEND] iio: pressure: ms5637: Use i2c_get_match_data() Biju Das
2023-09-10 13:43 ` Jonathan Cameron [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230910144305.17d7df5d@jic23-huawei \
    --to=jic23@kernel.org \
    --cc=andriy.shevchenko@linux.intel.com \
    --cc=biju.das.au@gmail.com \
    --cc=biju.das.jz@bp.renesas.com \
    --cc=lars@metafoo.de \
    --cc=linux-iio@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=u.kleine-koenig@pengutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox