From: Jonathan Cameron <jic23@kernel.org>
To: Ivan Mikhaylov <fr0st61te@gmail.com>
Cc: Lars-Peter Clausen <lars@metafoo.de>,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Conor Dooley <conor+dt@kernel.org>,
linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org,
devicetree@vger.kernel.org
Subject: Re: [PATCH v6 0/2] Add maxim max34408/34409 ADC driver and yaml
Date: Wed, 18 Oct 2023 19:32:30 +0100 [thread overview]
Message-ID: <20231018193230.60736165@jic23-huawei> (raw)
In-Reply-To: <20231014211254.16719-1-fr0st61te@gmail.com>
On Sun, 15 Oct 2023 00:12:52 +0300
Ivan Mikhaylov <fr0st61te@gmail.com> wrote:
> Add Maxim max34408/34409 ADC driver and yaml for it. Until now it
> supports only current monitioring function without overcurrent
> threshold/delay, shutdown delay configuration, alert interrupt.
>
> Changes from v1:
> - minor changes from Rob's comments for yaml
> - add ena, shtdn and make 4 inputs for R sense from Jonathan's comments for yaml
> - add _REG suffix and make prefix for bitmasks and statuses
> - add SCALE/OFFSET instead of AVG/PROCESSED from Jonathan and
> Lars-Peter comments
> - add chip data from Jonathan and Lars-Peter comments
> - minor changes from Lars-Peter and Jonathan comments for driver
>
> Changes from v2:
> - add channels into hardware description into yaml
> - add rsense property per channel
> - rename pins for shtdn and ena pins
> - make one array for input_rsense values
>
> Changes from v3:
> - change *_34408_OCT3 and 4 to *_34409_OCT3 and 4
> - change of_property_read_u32 to fwnode family calls
> - add i2c dev table
> - change of_match_device to i2c_of_match_device
> - change match->data to i2c_get_match_data
>
> Changes from v4:
> - minor changes in yaml
>
> Changes from v5:
> - name and minor changes to properties in yaml from Rob's comments
> - shtdn-enable-gpios -> powerdown-status-gpios from Krzysztof and
> Jonathan comments in yaml
> - minor changes to driver
>
> Ivan Mikhaylov (2):
> dt-bindings: adc: provide max34408/9 device tree binding document
> iio: adc: Add driver support for MAX34408/9
>
> .../bindings/iio/adc/maxim,max34408.yaml | 139 +++++++++
> drivers/iio/adc/Kconfig | 11 +
> drivers/iio/adc/Makefile | 1 +
> drivers/iio/adc/max34408.c | 276 ++++++++++++++++++
> 4 files changed, 427 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/iio/adc/maxim,max34408.yaml
> create mode 100644 drivers/iio/adc/max34408.c
>
Series applied to the togreg branch of iio.git and pushed out as testing.
We are very late in the cycle, so this is probably destined for 6.8
Jonathan
prev parent reply other threads:[~2023-10-18 18:32 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-14 21:12 [PATCH v6 0/2] Add maxim max34408/34409 ADC driver and yaml Ivan Mikhaylov
2023-10-14 21:12 ` [PATCH v6 1/2] dt-bindings: adc: provide max34408/9 device tree binding document Ivan Mikhaylov
2023-10-18 15:37 ` Conor Dooley
2023-10-14 21:12 ` [PATCH v6 2/2] iio: adc: Add driver support for MAX34408/9 Ivan Mikhaylov
2023-10-18 18:32 ` Jonathan Cameron [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231018193230.60736165@jic23-huawei \
--to=jic23@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=fr0st61te@gmail.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=lars@metafoo.de \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox