From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id D4416C001E0 for ; Sat, 21 Oct 2023 15:52:54 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231496AbjJUPwy (ORCPT ); Sat, 21 Oct 2023 11:52:54 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:35634 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229583AbjJUPwy (ORCPT ); Sat, 21 Oct 2023 11:52:54 -0400 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E7B7913E; Sat, 21 Oct 2023 08:52:52 -0700 (PDT) Received: by smtp.kernel.org (Postfix) with ESMTPSA id EE97FC433C8; Sat, 21 Oct 2023 15:52:49 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1697903572; bh=7TjlB9aoSZ9815DfMrxuJtQz6zC044xTw1Yj6BKuTms=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=b+K6XEqRGp9d0Vz81r4ZvvvUwfHB/srqOevZyaZHtrUXW1zBBo9BU3ofEhSIzRiu5 XPlvWw0voHmJ190ioNpvb4aHCYxAu21mqv9+JwVYDqLO2U2gctBpG0FkLRZ3MKWads P4r7msdXsstOtlp/uySkQbIbUjl9Dn5cl3D1YD5o1+FeG7t9xU5X8Ddtey7VA9l3Bz zPbHPH9z6vz//V106s86txXmPxUQFlt0aA2HiEDNaRYOfCsMjLCVTQSRZjZ+cUR3Ch 5+yhzOxqyLLlnuSUSUwweWkoCf3LRrp7lyjSxoYL97odTfxFJ4CjoUjvbFiUSAOEBH m5DqsV34bGngA== Date: Sat, 21 Oct 2023 16:52:45 +0100 From: Jonathan Cameron To: Andreas Klinger Cc: Andy Shevchenko , Lars-Peter Clausen , Angel Iglesias , Linus Walleij , Sergei Korolev , linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2] iio: bmp280: fix eoc interrupt usage Message-ID: <20231021165245.4f6c9aa3@jic23-huawei> In-Reply-To: References: <20231018152816.56589-1-ak@it-klinger.de> <20231019162209.18872-1-ak@it-klinger.de> X-Mailer: Claws Mail 4.1.1 (GTK 3.24.38; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-iio@vger.kernel.org On Thu, 19 Oct 2023 19:15:22 +0200 Andreas Klinger wrote: > Hi Andy, > > Andy Shevchenko schrieb am Do, 19. Okt 19:54: > > On Thu, Oct 19, 2023 at 06:22:09PM +0200, Andreas Klinger wrote: > > > Only the bmp085 can have an End-Of-Conversion (EOC) interrupt. But the > > > bmp085 and bmp180 share the same chip id. Therefore it's necessary to > > > distinguish the case in which the interrupt is set. > > > > > > Fix the if statement so that only when the interrupt is set and the chip > > > id is recognized the interrupt is requested. > > > > > > This bug exists since the support of EOC interrupt was introduced. > > > > > Fixes: aae953949651 ("iio: pressure: bmp280: add support for BMP085 EOC interrupt") > > > > As Jonathan already commented, this is part of a tag block below... > > > > > Also add a link to bmp085 datasheet for reference. > > > > > > > ...somewhere here. > > > > > Suggested-by: Sergei Korolev > > > Reviewed-by: Linus Walleij > > > Signed-off-by: Andreas Klinger > > > --- > > > v1 -> v2: Remove extra space (seen by Andy) > > > > > > And seems Jonathan mentioned that this is already fixed in his tree. > > Did I understand that correctly? > > I just read it in the archive. For some reason I didn't get Jonathans mail > yesterday. Sorry for the spam. btw, don't reply to an earlier version. New version is new email thread. Otherwise things get very tricky to follow once we have lots of versions Jonathan > > Andreas >