RE: [PATCH 11/17] ASoC: dt-bindings: samsung-i2s: add specific compatibles for existing SoC

Alim Akhtar
2023-11-11T01:37:26Z

> -----Original Message-----
> From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> Samsung Exynos SoC reuses several devices from older designs, thus
> historically we kept the old (block's) compatible only. This works fine and
> there is no bug here, however guidelines expressed in
> Documentation/devicetree/bindings/writing-bindings.rst state that:
> 1. Compatibles should be specific.
> 2. We should add new compatibles in case of bugs or features.
>
> Add compatibles specific to each SoC in front of all old-SoC-like compatibles.
>
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
>

Reviewed-by: Alim Akhtar <alim.akhtar@samsung.com>

> ---
>
> I propose to take the patch through Samsung SoC (me). See cover letter for
> explanation.
> ---
> .../mfd/samsung,exynos5433-lpass.yaml | 2 +-
> .../bindings/sound/samsung-i2s.yaml | 19 ++++++++++++-------
> 2 files changed, 13 insertions(+), 8 deletions(-)
(...)