* [PATCH v1] iio: adc: MCP3564: fix hardware identification logic
@ 2023-11-22 11:11 marius.cristea
2023-11-25 19:22 ` Jonathan Cameron
0 siblings, 1 reply; 2+ messages in thread
From: marius.cristea @ 2023-11-22 11:11 UTC (permalink / raw)
To: jic23, lars, lgirdwood, broonie; +Cc: linux-iio, linux-kernel, marius.cristea
From: Marius Cristea <marius.cristea@microchip.com>
In mcp3564_config() fix the hardware identification logic
based on the hardware ID registers. Second part of the code was
disabled by an logic error.
Fix a typo related to the "MODULE_DESCRIPTION".
Signed-off-by: Marius Cristea <marius.cristea@microchip.com>
---
drivers/iio/adc/mcp3564.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/iio/adc/mcp3564.c b/drivers/iio/adc/mcp3564.c
index e3f1de5fcc5a..e914a885a868 100644
--- a/drivers/iio/adc/mcp3564.c
+++ b/drivers/iio/adc/mcp3564.c
@@ -1122,7 +1122,7 @@ static int mcp3564_config(struct iio_dev *indio_dev)
enum mcp3564_ids ids;
int ret = 0;
unsigned int tmp = 0x01;
- bool err = true;
+ bool err = false;
/*
* The address is set on a per-device basis by fuses in the factory,
@@ -1509,5 +1509,5 @@ static struct spi_driver mcp3564_driver = {
module_spi_driver(mcp3564_driver);
MODULE_AUTHOR("Marius Cristea <marius.cristea@microchip.com>");
-MODULE_DESCRIPTION("Microchip MCP346x/MCP346xR and MCP356x/MCP346xR ADCs");
+MODULE_DESCRIPTION("Microchip MCP346x/MCP346xR and MCP356x/MCP356xR ADCs");
MODULE_LICENSE("GPL v2");
base-commit: 6543f376ec8aa90a6c1ed44b765f4f0d6c3eb1db
--
2.34.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH v1] iio: adc: MCP3564: fix hardware identification logic
2023-11-22 11:11 [PATCH v1] iio: adc: MCP3564: fix hardware identification logic marius.cristea
@ 2023-11-25 19:22 ` Jonathan Cameron
0 siblings, 0 replies; 2+ messages in thread
From: Jonathan Cameron @ 2023-11-25 19:22 UTC (permalink / raw)
To: marius.cristea; +Cc: lars, lgirdwood, broonie, linux-iio, linux-kernel
On Wed, 22 Nov 2023 13:11:06 +0200
<marius.cristea@microchip.com> wrote:
> From: Marius Cristea <marius.cristea@microchip.com>
>
> In mcp3564_config() fix the hardware identification logic
> based on the hardware ID registers. Second part of the code was
> disabled by an logic error.
> Fix a typo related to the "MODULE_DESCRIPTION".
>
> Signed-off-by: Marius Cristea <marius.cristea@microchip.com>
Fixes tag?
> ---
> drivers/iio/adc/mcp3564.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/iio/adc/mcp3564.c b/drivers/iio/adc/mcp3564.c
> index e3f1de5fcc5a..e914a885a868 100644
> --- a/drivers/iio/adc/mcp3564.c
> +++ b/drivers/iio/adc/mcp3564.c
> @@ -1122,7 +1122,7 @@ static int mcp3564_config(struct iio_dev *indio_dev)
> enum mcp3564_ids ids;
> int ret = 0;
> unsigned int tmp = 0x01;
> - bool err = true;
> + bool err = false;
>
> /*
> * The address is set on a per-device basis by fuses in the factory,
> @@ -1509,5 +1509,5 @@ static struct spi_driver mcp3564_driver = {
> module_spi_driver(mcp3564_driver);
>
> MODULE_AUTHOR("Marius Cristea <marius.cristea@microchip.com>");
> -MODULE_DESCRIPTION("Microchip MCP346x/MCP346xR and MCP356x/MCP346xR ADCs");
> +MODULE_DESCRIPTION("Microchip MCP346x/MCP346xR and MCP356x/MCP356xR ADCs");
> MODULE_LICENSE("GPL v2");
>
> base-commit: 6543f376ec8aa90a6c1ed44b765f4f0d6c3eb1db
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2023-11-25 19:22 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-11-22 11:11 [PATCH v1] iio: adc: MCP3564: fix hardware identification logic marius.cristea
2023-11-25 19:22 ` Jonathan Cameron
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).