From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 30E6A2F849; Sat, 25 Nov 2023 19:34:15 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="F0TKJUgq" Received: by smtp.kernel.org (Postfix) with ESMTPSA id C9FDBC433C8; Sat, 25 Nov 2023 19:34:07 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1700940855; bh=ErjCfl4uXkdScmDZgG34jOu3Ae6PwvX0QAhlDCF/QmA=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=F0TKJUgqGIaoVdzZLpXtYi8tIvDIWpnmJYL0TIQTb3pnOec5C/I0n4mlLi2URZFzl t3JMaQV1nWYoeI6zKdjRIBAG3mcYHSDw7JT/0l+VdQFxb3w7AULO7hBuUImHhJ2/zP LcJvF6p4cyZHZDVZ8foGDPPCEQSYrTGNaPdGW5NrtDs3GLpvah5mbzNTovZjqHRxTt lbu5Z4czpHy/eb1yD+tk6RUVoVBOkWFIqIhYBiZfU7xvzH1yNTc5a4f0cn6jF/654F O+Ex4IBbZyngjuYmeeNyGZ2pcuj+oVsnNu7Dppk0Zy6Cn/gZmxTmZgIF8W8HFCDO1e pdWjGOgfVbxDw== Date: Sat, 25 Nov 2023 19:34:03 +0000 From: Jonathan Cameron To: Dmitry Baryshkov Cc: Krzysztof Kozlowski , Jishnu Prakash , robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org, conor+dt@kernel.org, agross@kernel.org, andersson@kernel.org, konrad.dybcio@linaro.org, daniel.lezcano@linaro.org, linus.walleij@linaro.org, linux-arm-msm@vger.kernel.org, andriy.shevchenko@linux.intel.com, quic_subbaram@quicinc.com, quic_collinsd@quicinc.com, quic_amelende@quicinc.com, quic_kamalw@quicinc.com, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, marijn.suijten@somainline.org, lars@metafoo.de, luca@z3ntu.xyz, linux-iio@vger.kernel.org, lee@kernel.org, rafael@kernel.org, rui.zhang@intel.com, lukasz.luba@arm.com, cros-qcom-dts-watchers@chromium.org, sboyd@kernel.org, linux-pm@vger.kernel.org, linux-arm-msm-owner@vger.kernel.org, kernel@quicinc.com Subject: Re: [PATCH V2 3/3] dt-bindings: iio/adc: Move QCOM ADC bindings to iio/adc folder Message-ID: <20231125193403.77400aca@jic23-huawei> In-Reply-To: References: <20231116032644.753370-1-quic_jprakash@quicinc.com> <20231116032644.753370-2-quic_jprakash@quicinc.com> X-Mailer: Claws Mail 4.1.1 (GTK 3.24.38; x86_64-pc-linux-gnu) Precedence: bulk X-Mailing-List: linux-iio@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit On Thu, 16 Nov 2023 17:27:53 +0200 Dmitry Baryshkov wrote: > On Thu, 16 Nov 2023 at 13:44, Krzysztof Kozlowski > wrote: > > > > On 16/11/2023 04:26, Jishnu Prakash wrote: > > > There are several files containing QCOM ADC macros for channel names > > > right now in the include/dt-bindings/iio folder. Since all of these > > > are specifically for adc, move the files to the > > > include/dt-bindings/iio/adc folder. > > > > > > Also update all affected devicetree and driver files to fix compilation > > > errors seen with this move and update documentation files to fix > > > dtbinding check errors for the same. > > > > > > Signed-off-by: Jishnu Prakash > > > --- > > > .../devicetree/bindings/iio/adc/qcom,spmi-vadc.yaml | 4 ++-- > > > Documentation/devicetree/bindings/mfd/qcom,spmi-pmic.yaml | 2 +- > > > .../devicetree/bindings/thermal/qcom-spmi-adc-tm-hc.yaml | 2 +- > > > .../devicetree/bindings/thermal/qcom-spmi-adc-tm5.yaml | 6 +++--- > > > arch/arm64/boot/dts/qcom/pm2250.dtsi | 2 +- > > > arch/arm64/boot/dts/qcom/pm6125.dtsi | 2 +- > > > > NAK, bindings are always separate from the other changes. > > In this case I'd even try to appeal :-) > They are doing `git mv` and then fixing the failouts. I think this > should be fine. Agreed. The only easy way around this would be to put some dummy headers that include the new ones in old locations temporary basis then delete them later. I'm fine with that if Kryzsztof prefers it that way. Not too disruptive. Jonathan > > > > > Please run scripts/checkpatch.pl and fix reported warnings. Some > > warnings can be ignored, but the code here looks like it needs a fix. > > Feel free to get in touch if the warning is not clear. > > > > Best regards, > > Krzysztof > > > >