Re: [PATCH v3 1/2] dt-bindings: iio: adc: adding support for PAC193X

Krzysztof Kozlowski
2023-11-16T15:01:45Z

On 15/11/2023 14:44, marius.cristea@microchip.com wrote:
> From: Marius Cristea <marius.cristea@microchip.com>
>
> This is the device tree schema for iio driver for
> Microchip PAC193X series of Power Monitors with Accumulator.
>
> Signed-off-by: Marius Cristea <marius.cristea@microchip.com>
> ---
> .../bindings/iio/adc/microchip,pac1934.yaml | 137 ++++++++++++++++++
> 1 file changed, 137 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/iio/adc/microchip,pac1934.yaml
>
> diff --git a/Documentation/devicetree/bindings/iio/adc/microchip,pac1934.yaml b/Documentation/devicetree/bindings/iio/adc/microchip,pac1934.yaml
> new file mode 100644
> index 000000000000..2609cb19c377
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/iio/adc/microchip,pac1934.yaml
> @@ -0,0 +1,137 @@
> +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/iio/adc/microchip,pac1934.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Microchip PAC1934 Power Monitors with Accumulator
> +
> +maintainers:
> + - Marius Cristea <marius.cristea@microchip.com>
> +
> +description: |
> + This device is part of the Microchip family of Power Monitors with Accumulator.
> + The datasheet for PAC1931, PAC1932, PAC1933 and PAC1934 can be found here:
> + https://ww1.microchip.com/downloads/aemDocuments/documents/OTH/ProductDocuments/DataSheets/PAC1931-Family-Data-Sheet-DS20005850E.pdf
> +
> +properties:
> + compatible:
> + enum:
> + - microchip,pac1931
> + - microchip,pac1932
> + - microchip,pac1933
> + - microchip,pac1934
> +
> + reg:
> + maxItems: 1
> +
> + "#address-cells":
> + const: 1
> +
> + "#size-cells":
> + const: 0
> +
> + interrupts:
> + maxItems: 1
> +
> + microchip,slow-io:
> + type: boolean
> + description: |
> + A GPIO used to trigger a change is sampling rate (lowering the chip power consumption).

Use Linux coding style wrapping (as described in Linux Coding style). I
am not going to tell you numbers because I want you to read the document
first.

This is boolean, not GPIO. I don't understand. "A GPIO", so any GPIO or
some specific? How is this property related to GPIO?

> + If configured in SLOW mode, if this pin is forced high, sampling rate is forced to eight

This pin? This is boolean, not a GPIO. GPIOs are phandles.

> + samples/second. When it is forced low, the sampling rate is 1024 samples/second unless
> + a different sample rate has been programmed.
> +
> +patternProperties:
> + "^channel@[1-4]+$":
> + type: object
> + $ref: adc.yaml
> + description: Represents the external channels which are connected to the ADC.
> +
> + properties:
> + reg:
> + items:
> + minimum: 1
> + maximum: 4
> +
> + shunt-resistor-micro-ohms:
> + description: |
> + Value in micro Ohms of the shunt resistor connected between
> + the SENSE+ and SENSE- inputs, across which the current is measured. Value
> + is needed to compute the scaling of the measured current.
> +
> + required:
> + - reg
> + - shunt-resistor-micro-ohms
> +
> + unevaluatedProperties: false
> +
> +required:
> + - compatible
> + - reg
> + - "#address-cells"
> + - "#size-cells"
> +
> +allOf:
> + - if:
> + properties:
> + compatible:
> + contains:
> + const: interrupts

I don't understand what do you want to say here. I am also 100% sure you
did not test it on a real case (maybe example passes but nothing more).

> + then:
> + properties:
> + microchip,slow-io: false
> + else:
> + if:
> + properties:
> + compatible:
> + contains:
> + const: microchip,slow-io
> + then:
> + properties:
> + interrupts: false

Best regards,
Krzysztof