From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5E1ACD270 for ; Sun, 26 Nov 2023 16:03:22 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="nR4IXaLO" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 7592EC433C7; Sun, 26 Nov 2023 16:03:18 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1701014601; bh=Q+B4Zo9g6whYMeWtEu/77DE3UqeXmkHDSf5vckYHPUc=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=nR4IXaLOVQTz9kvT3MIaAnJpK4sVA7CdFRTqPJIFydVw4QeHWSCxemjLWbX8oJdJx UBZpTEk5lGBQBz6XtlRbKFBiIpdSnIyMxPCpMIqAe5LmYA1fmZuOG1L8i8oxTrvmAI 9ji5SpoxGk1AzQdvWsXFrsaurtdlpI71YTD5Gxmn4qyLOyksoqsM0cpZBdM+9iSlu1 vubmOe7V+McZUK2/zyzLr/EPClUD8DGi/3NZPPdTE6daTVS9U8eUZAGAEL3XPsmv9o 7z21JB6SmHQfzB+aAYsyUhTPO4HHA4ghg92AGC27a0kPnKDlIxfx4u1OpJc05rnwDt ijl3nujwtzPiQ== Date: Sun, 26 Nov 2023 16:03:12 +0000 From: Jonathan Cameron To: haibo.chen@nxp.com Cc: lars@metafoo.de, shawnguo@kernel.org, s.hauer@pengutronix.de, kernel@pengutronix.de, festevam@gmail.com, linux-imx@nxp.com, linux-iio@vger.kernel.org Subject: Re: [PATCH] iio: adc: imx93: add four channels for imx93 adc Message-ID: <20231126160312.2ef8a307@jic23-huawei> In-Reply-To: <20231116071026.611269-1-haibo.chen@nxp.com> References: <20231116071026.611269-1-haibo.chen@nxp.com> X-Mailer: Claws Mail 4.1.1 (GTK 3.24.38; x86_64-pc-linux-gnu) Precedence: bulk X-Mailing-List: linux-iio@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit On Thu, 16 Nov 2023 15:10:26 +0800 haibo.chen@nxp.com wrote: > From: Haibo Chen > > According to the spec, this ADC totally support 8 channels. > i.MX93 contain this ADC with 4 channels connected to pins in > the package. i.MX95 contain this ADC with 8 channels connected > to pins in the package. > > Signed-off-by: Haibo Chen Should I treat this as a fix? If so could you reply with a fixes tag please Thanks, Jonathan > --- > drivers/iio/adc/imx93_adc.c | 4 ++++ > 1 file changed, 4 insertions(+) > > diff --git a/drivers/iio/adc/imx93_adc.c b/drivers/iio/adc/imx93_adc.c > index 9bb1e4ba1aee..4ccf4819f1f1 100644 > --- a/drivers/iio/adc/imx93_adc.c > +++ b/drivers/iio/adc/imx93_adc.c > @@ -93,6 +93,10 @@ static const struct iio_chan_spec imx93_adc_iio_channels[] = { > IMX93_ADC_CHAN(1), > IMX93_ADC_CHAN(2), > IMX93_ADC_CHAN(3), > + IMX93_ADC_CHAN(4), > + IMX93_ADC_CHAN(5), > + IMX93_ADC_CHAN(6), > + IMX93_ADC_CHAN(7), > }; > > static void imx93_adc_power_down(struct imx93_adc *adc)