From: Jonathan Cameron <jic23@kernel.org>
To: Su Hui <suhui@nfschina.com>
Cc: lars@metafoo.de, jean-baptiste.maneyrol@tdk.com,
andy.shevchenko@gmail.com, chenhuiz@axis.com,
mranostay@gmail.com, linux-iio@vger.kernel.org,
linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org
Subject: Re: [PATCH v3] iio: imu: inv_mpu6050: fix an error code problem in inv_mpu6050_read_raw
Date: Sun, 26 Nov 2023 17:09:35 +0000 [thread overview]
Message-ID: <20231126170935.3074a06e@jic23-huawei> (raw)
In-Reply-To: <20231030020218.65728-1-suhui@nfschina.com>
On Mon, 30 Oct 2023 10:02:19 +0800
Su Hui <suhui@nfschina.com> wrote:
> inv_mpu6050_sensor_show() can return -EINVAL or IIO_VAL_INT. Return the
> true value rather than only return IIO_VAL_INT.
>
> Fixes: d5098447147c ("iio: imu: mpu6050: add calibration offset support")
> Signed-off-by: Su Hui <suhui@nfschina.com>
Applied to the fixes-togreg branch of iio.git.
It's independent enough from the improved error reporting that they can hopefully
got through different branches.
Thanks,
Jonathan
> ---
> v3:
> - add Fixes tag
> v2:
> - fix the error of commit title.
> v1:
> - https://lore.kernel.org/all/20231020091413.205743-2-suhui@nfschina.com/
>
> drivers/iio/imu/inv_mpu6050/inv_mpu_core.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/iio/imu/inv_mpu6050/inv_mpu_core.c b/drivers/iio/imu/inv_mpu6050/inv_mpu_core.c
> index 29f906c884bd..a9a5fb266ef1 100644
> --- a/drivers/iio/imu/inv_mpu6050/inv_mpu_core.c
> +++ b/drivers/iio/imu/inv_mpu6050/inv_mpu_core.c
> @@ -749,13 +749,13 @@ inv_mpu6050_read_raw(struct iio_dev *indio_dev,
> ret = inv_mpu6050_sensor_show(st, st->reg->gyro_offset,
> chan->channel2, val);
> mutex_unlock(&st->lock);
> - return IIO_VAL_INT;
> + return ret;
> case IIO_ACCEL:
> mutex_lock(&st->lock);
> ret = inv_mpu6050_sensor_show(st, st->reg->accl_offset,
> chan->channel2, val);
> mutex_unlock(&st->lock);
> - return IIO_VAL_INT;
> + return ret;
>
> default:
> return -EINVAL;
prev parent reply other threads:[~2023-11-26 17:09 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-30 2:02 [PATCH v3] iio: imu: inv_mpu6050: fix an error code problem in inv_mpu6050_read_raw Su Hui
2023-11-26 17:09 ` Jonathan Cameron [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231126170935.3074a06e@jic23-huawei \
--to=jic23@kernel.org \
--cc=andy.shevchenko@gmail.com \
--cc=chenhuiz@axis.com \
--cc=jean-baptiste.maneyrol@tdk.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=lars@metafoo.de \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mranostay@gmail.com \
--cc=suhui@nfschina.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox