From: Jonathan Cameron <jic23@kernel.org>
To: Jagath Jog J <jagathjog1996@gmail.com>
Cc: andriy.shevchenko@linux.intel.com, oe-kbuild-all@lists.linux.dev,
lkp@intel.com, linux-iio@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] iio: imu: bmi323: Make the local structures static
Date: Sun, 26 Nov 2023 18:06:37 +0000 [thread overview]
Message-ID: <20231126180637.1a832574@jic23-huawei> (raw)
In-Reply-To: <20231108035831.5889-1-jagathjog1996@gmail.com>
On Wed, 8 Nov 2023 09:28:31 +0530
Jagath Jog J <jagathjog1996@gmail.com> wrote:
> Make the local structures static within their respective driver files.
>
> Reported-by: kernel test robot <lkp@intel.com>
> Closes: https://lore.kernel.org/oe-kbuild-all/202311070530.qKhLTz1Y-lkp@intel.com/
> Fixes: b512c767e7bc ("iio: imu: Add driver for BMI323 IMU")
Applied to the togreg branch of iio.git but I dropped this fixes tag because
it's already wrong due to a rebase and that may well happen again.
Probably better to just not have one in this case :(
Jonathan
> Signed-off-by: Jagath Jog J <jagathjog1996@gmail.com>
> ---
> drivers/iio/imu/bmi323/bmi323_i2c.c | 2 +-
> drivers/iio/imu/bmi323/bmi323_spi.c | 2 +-
> 2 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/iio/imu/bmi323/bmi323_i2c.c b/drivers/iio/imu/bmi323/bmi323_i2c.c
> index 0008e186367d..20a8001b9956 100644
> --- a/drivers/iio/imu/bmi323/bmi323_i2c.c
> +++ b/drivers/iio/imu/bmi323/bmi323_i2c.c
> @@ -66,7 +66,7 @@ static struct regmap_bus bmi323_regmap_bus = {
> .write = bmi323_regmap_i2c_write,
> };
>
> -const struct regmap_config bmi323_i2c_regmap_config = {
> +static const struct regmap_config bmi323_i2c_regmap_config = {
> .reg_bits = 8,
> .val_bits = 16,
> .max_register = BMI323_CFG_RES_REG,
> diff --git a/drivers/iio/imu/bmi323/bmi323_spi.c b/drivers/iio/imu/bmi323/bmi323_spi.c
> index 6dc3352dd714..7b1e8127d0dd 100644
> --- a/drivers/iio/imu/bmi323/bmi323_spi.c
> +++ b/drivers/iio/imu/bmi323/bmi323_spi.c
> @@ -41,7 +41,7 @@ static struct regmap_bus bmi323_regmap_bus = {
> .write = bmi323_regmap_spi_write,
> };
>
> -const struct regmap_config bmi323_spi_regmap_config = {
> +static const struct regmap_config bmi323_spi_regmap_config = {
> .reg_bits = 8,
> .val_bits = 16,
> .pad_bits = 8,
prev parent reply other threads:[~2023-11-26 18:06 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-08 3:58 [PATCH] iio: imu: bmi323: Make the local structures static Jagath Jog J
2023-11-26 18:06 ` Jonathan Cameron [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231126180637.1a832574@jic23-huawei \
--to=jic23@kernel.org \
--cc=andriy.shevchenko@linux.intel.com \
--cc=jagathjog1996@gmail.com \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lkp@intel.com \
--cc=oe-kbuild-all@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox