From: Jonathan Cameron <jic23@kernel.org>
To: Marek Vasut <marex@denx.de>
Cc: Jonathan Cameron <Jonathan.Cameron@Huawei.com>,
linux-iio@vger.kernel.org,
Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
Matti Vaittinen <mazziesaccount@gmail.com>,
Alexander Stein <alexander.stein@ew.tq-group.com>,
Andre Werner <andre.werner@systec-electronic.com>,
Bjorn Helgaas <bhelgaas@google.com>,
Conor Dooley <conor+dt@kernel.org>,
Fabio Estevam <festevam@denx.de>,
Guenter Roeck <linux@roeck-us.net>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Lars-Peter Clausen <lars@metafoo.de>,
Luca Ceresoli <luca.ceresoli@bootlin.com>,
Mark Brown <broonie@kernel.org>,
Naresh Solanki <naresh.solanki@9elements.com>,
Patrick Rudolph <patrick.rudolph@9elements.com>,
Rob Herring <robh+dt@kernel.org>,
Stefan Windfeldt-Prytz <stefan.windfeldt-prytz@axis.com>,
Vincent Tremblay <vincent@vtremblay.dev>,
devicetree@vger.kernel.org
Subject: Re: [PATCH v5 2/2] iio: light: isl76682: Add ISL76682 driver
Date: Mon, 4 Dec 2023 11:13:17 +0000 [thread overview]
Message-ID: <20231204111317.22c679ed@jic23-huawei> (raw)
In-Reply-To: <00a21ed4-18b5-4aca-8dd6-628d475664e7@denx.de>
On Sat, 2 Dec 2023 07:48:12 +0100
Marek Vasut <marex@denx.de> wrote:
> On 12/1/23 19:17, Jonathan Cameron wrote:
> > On Sun, 26 Nov 2023 23:09:36 +0100
> > Marek Vasut <marex@denx.de> wrote:
> >
> >> On 11/26/23 19:16, Jonathan Cameron wrote:
> >>> On Sat, 25 Nov 2023 23:26:23 +0100
> >>> Marek Vasut <marex@denx.de> wrote:
> >>>
> >>>> The ISL76682 is very basic ALS which only supports ALS or IR mode
> >>>> in four ranges, 1k/4k/16k/64k LUX. There is no IRQ support or any
> >>>> other fancy functionality.
> >>>>
> >>>> Reviewed-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> >>>> Reviewed-by: Matti Vaittinen <mazziesaccount@gmail.com>
> >>>> Signed-off-by: Marek Vasut <marex@denx.de>
> >>>
> >>> Hi Marek,
> >>>
> >>> One last question + a comment in general. Act on that if you like.
> >>>
> >>> Thanks,
> >>>
> >>> Jonathan
> >>>
> >>>
> >>>> +static int integration_time_available[] = { 0, ISL76682_INT_TIME_US };
> >>>
> >>> Why have an available attribute for a single value. Is it useful for anything?
> >>
> >> To report it to userspace, iio-sensor-proxy uses that to control the ALS
> >> poll interval .
> >
> > It should use integration_time, not the associated available attribute.
>
> So, what should I do with this feedback ?
>
> I did send the V6 already, so shall I change anything in V7 ?
I'll reply there. Just noticed some other oddities around available.
next prev parent reply other threads:[~2023-12-04 11:13 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-25 22:26 [PATCH v5 1/2] dt-bindings: iio: light: isl76682: Document ISL76682 Marek Vasut
2023-11-25 22:26 ` [PATCH v5 2/2] iio: light: isl76682: Add ISL76682 driver Marek Vasut
2023-11-26 18:16 ` Jonathan Cameron
2023-11-26 22:09 ` Marek Vasut
2023-12-01 18:17 ` Jonathan Cameron
2023-12-02 6:48 ` Marek Vasut
2023-12-04 11:13 ` Jonathan Cameron [this message]
2023-11-26 19:33 ` Dr.-Ing. Andre Werner
2023-11-26 22:17 ` Marek Vasut
2023-12-01 18:20 ` Jonathan Cameron
2023-12-02 6:46 ` Marek Vasut
2023-11-27 16:11 ` Andy Shevchenko
2023-11-27 16:13 ` Andy Shevchenko
2023-11-27 20:52 ` Marek Vasut
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231204111317.22c679ed@jic23-huawei \
--to=jic23@kernel.org \
--cc=Jonathan.Cameron@Huawei.com \
--cc=alexander.stein@ew.tq-group.com \
--cc=andre.werner@systec-electronic.com \
--cc=andriy.shevchenko@linux.intel.com \
--cc=bhelgaas@google.com \
--cc=broonie@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=festevam@denx.de \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=lars@metafoo.de \
--cc=linux-iio@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=luca.ceresoli@bootlin.com \
--cc=marex@denx.de \
--cc=mazziesaccount@gmail.com \
--cc=naresh.solanki@9elements.com \
--cc=patrick.rudolph@9elements.com \
--cc=robh+dt@kernel.org \
--cc=stefan.windfeldt-prytz@axis.com \
--cc=vincent@vtremblay.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox