From: Jonathan Cameron <jic23@kernel.org>
To: linux-iio@vger.kernel.org
Cc: Jonathan Cameron <Jonathan.Cameron@huawei.com>,
kernel test robot <lkp@intel.com>
Subject: Re: [PATCH] iio: light: pa1203001: Drop ACPI_PTR() protection.
Date: Mon, 4 Dec 2023 17:10:52 +0000 [thread overview]
Message-ID: <20231204171052.40def421@jic23-huawei> (raw)
In-Reply-To: <20231116192711.366441-1-jic23@kernel.org>
On Thu, 16 Nov 2023 19:27:11 +0000
Jonathan Cameron <jic23@kernel.org> wrote:
> From: Jonathan Cameron <Jonathan.Cameron@huawei.com>
>
> The extra cost of always including the acpi_device_id table is trivial
> vs the complexity of adding guards or __maybe_unused markings so
> just stop using the ACPI_PTR() macro.
>
> Reported-by: kernel test robot <lkp@intel.com>
> Closes: https://lore.kernel.org/oe-kbuild-all/202311160851.FDA4CDVE-lkp@intel.com/
> Signed-off-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
Meh. Guess not that exciting to review :)
Applied anyway, so hopefully I haven't shot myself in the foot.
Jonathan
> ---
> drivers/iio/light/pa12203001.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/iio/light/pa12203001.c b/drivers/iio/light/pa12203001.c
> index ed241598aefb..636432c45651 100644
> --- a/drivers/iio/light/pa12203001.c
> +++ b/drivers/iio/light/pa12203001.c
> @@ -472,7 +472,7 @@ static struct i2c_driver pa12203001_driver = {
> .driver = {
> .name = PA12203001_DRIVER_NAME,
> .pm = &pa12203001_pm_ops,
> - .acpi_match_table = ACPI_PTR(pa12203001_acpi_match),
> + .acpi_match_table = pa12203001_acpi_match,
> },
> .probe = pa12203001_probe,
> .remove = pa12203001_remove,
prev parent reply other threads:[~2023-12-04 17:10 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-16 19:27 [PATCH] iio: light: pa1203001: Drop ACPI_PTR() protection Jonathan Cameron
2023-12-04 17:10 ` Jonathan Cameron [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231204171052.40def421@jic23-huawei \
--to=jic23@kernel.org \
--cc=Jonathan.Cameron@huawei.com \
--cc=linux-iio@vger.kernel.org \
--cc=lkp@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox