Linux IIO development
 help / color / mirror / Atom feed
From: Rob Herring <robh@kernel.org>
To: Jonathan Cameron <jic23@kernel.org>
Cc: Nuno Sa <nuno.sa@analog.com>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	Frank Rowand <frowand.list@gmail.com>,
	devicetree@vger.kernel.org, linux-iio@vger.kernel.org,
	Lars-Peter Clausen <lars@metafoo.de>,
	Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
	Olivier Moysan <olivier.moysan@foss.st.com>,
	"Rafael J. Wysocki" <rafael@kernel.org>,
	Michael Hennerich <Michael.Hennerich@analog.com>,
	Conor Dooley <conor+dt@kernel.org>
Subject: Re: [PATCH v6 2/8] dt-bindings: adc: axi-adc: update bindings for backend framework
Date: Mon, 22 Jan 2024 09:34:36 -0600	[thread overview]
Message-ID: <20240122153436.GA601827-robh@kernel.org> (raw)
In-Reply-To: <20240121171720.47b61298@jic23-huawei>

On Sun, Jan 21, 2024 at 05:17:20PM +0000, Jonathan Cameron wrote:
> On Fri, 19 Jan 2024 11:15:56 -0600
> Rob Herring <robh@kernel.org> wrote:
> 
> > On Fri, 19 Jan 2024 17:00:48 +0100, Nuno Sa wrote:
> > > 'adi,adc-dev' is now deprecated and must not be used anymore. Hence,
> > > also remove it from being required.
> > > 
> > > The reason why it's being deprecated is because the axi-adc CORE is now
> > > an IIO service provider hardware (IIO backends) for consumers to make use
> > > of. Before, the logic with 'adi,adc-dev' was the opposite (it was kind
> > > of consumer referencing other nodes/devices) and that proved to be wrong
> > > and to not scale.
> > > 
> > > Now, IIO consumers of this hardware are expected to reference it using the
> > > io-backends property. Hence, the new '#io-backend-cells' is being added
> > > so the device is easily identified as a provider.
> > > 
> > > Signed-off-by: Nuno Sa <nuno.sa@analog.com>
> > > ---
> > >  Documentation/devicetree/bindings/iio/adc/adi,axi-adc.yaml | 8 +++++---
> > >  1 file changed, 5 insertions(+), 3 deletions(-)
> > >   
> > 
> > My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check'
> > on your patch (DT_CHECKER_FLAGS is new in v5.13):
> > 
> > yamllint warnings/errors:
> > ./Documentation/devicetree/bindings/iio/adc/adi,axi-adc.yaml:45:5: [error] syntax error: could not find expected ':' (syntax)
> If this is all that comes up for v6, I can fix it up whilst applying.

I would not recommend that unless you run the DT checks. This is a YAML 
error which is just the first thing that has to be valid. After that, we 
check against the DT meta-schema. Then we check all the examples 
(because any example could use any schema).

Though, it looks like the above is the only issue.

Reviewed-by: Rob Herring <robh@kernel.org>

Rob

  reply	other threads:[~2024-01-22 15:34 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-01-19 16:00 [PATCH v6 0/8] iio: add new backend framework Nuno Sa via B4 Relay
2024-01-19 16:00 ` [PATCH v6 1/8] dt-bindings: adc: ad9467: add new io-backend property Nuno Sa via B4 Relay
2024-01-19 17:15   ` Rob Herring
2024-01-22 15:37     ` Rob Herring
2024-01-22 16:01       ` Nuno Sá
2024-01-22 19:16         ` Jonathan Cameron
2024-01-19 16:00 ` [PATCH v6 2/8] dt-bindings: adc: axi-adc: update bindings for backend framework Nuno Sa via B4 Relay
2024-01-19 17:15   ` Rob Herring
2024-01-21 17:17     ` Jonathan Cameron
2024-01-22 15:34       ` Rob Herring [this message]
2024-01-22 19:18         ` Jonathan Cameron
2024-01-19 16:00 ` [PATCH v6 3/8] driver: core: allow modifying device_links flags Nuno Sa via B4 Relay
2024-01-21 17:20   ` Jonathan Cameron
2024-01-19 16:00 ` [PATCH v6 4/8] of: property: add device link support for io-backends Nuno Sa via B4 Relay
2024-01-19 16:00 ` [PATCH v6 5/8] iio: buffer-dmaengine: export buffer alloc and free functions Nuno Sa via B4 Relay
2024-01-19 16:00 ` [PATCH v6 6/8] iio: add the IIO backend framework Nuno Sa via B4 Relay
2024-01-19 16:00 ` [PATCH v6 7/8] iio: adc: ad9467: convert to " Nuno Sa via B4 Relay
2024-01-21 17:52   ` Jonathan Cameron
2024-01-22  8:33     ` Nuno Sá
2024-01-19 16:00 ` [PATCH v6 8/8] iio: adc: adi-axi-adc: move " Nuno Sa via B4 Relay
2024-01-21 17:57 ` [PATCH v6 0/8] iio: add new " Jonathan Cameron
2024-01-22  8:36   ` Nuno Sá

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240122153436.GA601827-robh@kernel.org \
    --to=robh@kernel.org \
    --cc=Michael.Hennerich@analog.com \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=frowand.list@gmail.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=jic23@kernel.org \
    --cc=krzysztof.kozlowski+dt@linaro.org \
    --cc=lars@metafoo.de \
    --cc=linux-iio@vger.kernel.org \
    --cc=nuno.sa@analog.com \
    --cc=olivier.moysan@foss.st.com \
    --cc=rafael@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox