From: Jonathan Cameron <jic23@kernel.org>
To: Lorenzo Bianconi <lorenzo@kernel.org>
Cc: linux-iio@vger.kernel.org, lorenzo.bianconi@redhat.com,
devicetree@vger.kernel.org, robh+dt@kernel.org,
krzysztof.kozlowski+dt@linaro.org
Subject: Re: [PATCH 2/2] dt-bindings: iio: imu: st_lsm6dsx: add asm330lhhxg1
Date: Sat, 27 Jan 2024 15:04:26 +0000 [thread overview]
Message-ID: <20240127150426.4994a6a0@jic23-huawei> (raw)
In-Reply-To: <90d675537e58c9c339545a895e8164a843821682.1706093274.git.lorenzo@kernel.org>
On Wed, 24 Jan 2024 11:52:34 +0100
Lorenzo Bianconi <lorenzo@kernel.org> wrote:
> Add device bindings for asm330lhhxg1 IMU sensor.
> Use asm330lhhx as fallback device for asm330lhhxg1 since it implements
> all the features currently supported by asm330lhhxg1.
Can we clarify if the hardware of the asm330lhhxg1 supports
1) Exactly the same features as the asm330lhhx
(Valid use for a fallback compatible, because we might find
bugs etc in future).
2) More features, but the asm330lhhx features set is a subset.
(Most valid use for a fallback compatible)
3) Different features from the asm330llhhx but driver only supports
a set both support? (this is a problem)
I 'think' it is 2 from your text, but I'm not 100% sure I've understood
correctly.
>
> Signed-off-by: Lorenzo Bianconi <lorenzo@kernel.org>
> ---
> Documentation/devicetree/bindings/iio/imu/st,lsm6dsx.yaml | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/iio/imu/st,lsm6dsx.yaml b/Documentation/devicetree/bindings/iio/imu/st,lsm6dsx.yaml
> index 28b667a9cb76..7ba3de66a2e1 100644
> --- a/Documentation/devicetree/bindings/iio/imu/st,lsm6dsx.yaml
> +++ b/Documentation/devicetree/bindings/iio/imu/st,lsm6dsx.yaml
> @@ -49,6 +49,9 @@ properties:
> - items:
> - const: st,asm330lhb
> - const: st,asm330lhh
> + - items:
> + - const: st,asm330lhhxg1
> + - const: st,asm330lhhx
>
> reg:
> maxItems: 1
next prev parent reply other threads:[~2024-01-27 15:04 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-24 10:52 [PATCH 0/2] add support for ASM330LHHXG1 Lorenzo Bianconi
2024-01-24 10:52 ` [PATCH 1/2] iio: imu: st_lsm6dsx: add support to ASM330LHHXG1 Lorenzo Bianconi
2024-01-27 15:00 ` Jonathan Cameron
2024-01-28 10:38 ` Lorenzo Bianconi
2024-01-24 10:52 ` [PATCH 2/2] dt-bindings: iio: imu: st_lsm6dsx: add asm330lhhxg1 Lorenzo Bianconi
2024-01-27 15:04 ` Jonathan Cameron [this message]
2024-01-28 10:35 ` Lorenzo Bianconi
2024-01-28 13:38 ` Jonathan Cameron
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240127150426.4994a6a0@jic23-huawei \
--to=jic23@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-iio@vger.kernel.org \
--cc=lorenzo.bianconi@redhat.com \
--cc=lorenzo@kernel.org \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox