Linux IIO development
 help / color / mirror / Atom feed
From: Jonathan Cameron <jic23@kernel.org>
To: Andrew Davis <afd@ti.com>
Cc: "Lars-Peter Clausen" <lars@metafoo.de>,
	"Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>,
	linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/4] iio: health: afe4403: Use devm action helper for regulator disable
Date: Sat, 27 Jan 2024 15:48:36 +0000	[thread overview]
Message-ID: <20240127154836.153127a3@jic23-huawei> (raw)
In-Reply-To: <20240123140918.215818-1-afd@ti.com>

On Tue, 23 Jan 2024 08:09:15 -0600
Andrew Davis <afd@ti.com> wrote:

> Use a device lifecycle managed action for regulator disable function.
> This helps prevent mistakes like unregistering out of order in cleanup
> functions and forgetting to unregister on error paths.
> 
> Signed-off-by: Andrew Davis <afd@ti.com>
Hi Andrew,

All applied.

You could make use of dev_err_probe() as well to save a few lines if
you want to (as a follow up patch).

Thanks,

Jonathan

      parent reply	other threads:[~2024-01-27 15:48 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-01-23 14:09 [PATCH 1/4] iio: health: afe4403: Use devm action helper for regulator disable Andrew Davis
2024-01-23 14:09 ` [PATCH 2/4] iio: health: afe4403: Use devm IIO helpers Andrew Davis
2024-01-23 14:09 ` [PATCH 3/4] iio: health: afe4404: Use devm action helper for regulator disable Andrew Davis
2024-01-23 14:09 ` [PATCH 4/4] iio: health: afe4404: Use devm IIO helpers Andrew Davis
2024-01-27 15:48 ` Jonathan Cameron [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240127154836.153127a3@jic23-huawei \
    --to=jic23@kernel.org \
    --cc=afd@ti.com \
    --cc=lars@metafoo.de \
    --cc=linux-iio@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=u.kleine-koenig@pengutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox