From: Jonathan Cameron <jic23@kernel.org>
To: "Nuno Sá" <noname.nuno@gmail.com>
Cc: linux-iio@vger.kernel.org, David Lechner <dlechner@baylibre.com>,
Peter Zijlstra <peterz@infradead.org>,
Jonathan Cameron <Jonathan.Cameron@huawei.com>
Subject: Re: [PATCH 03/10] iio: accel: adxl367: Use automated cleanup for locks and iio direct mode.
Date: Sun, 4 Feb 2024 13:48:17 +0000 [thread overview]
Message-ID: <20240204134817.1a2dff4f@jic23-huawei> (raw)
In-Reply-To: <270d95aa0190520c443eaaa94c30b5d4d9c64389.camel@gmail.com>
> > -out:
> > - mutex_unlock(&st->lock);
> > + ret = adxl367_set_measure_en(st, true);
> > + if (ret)
> > + return ret;
> >
> > - iio_device_release_direct_mode(indio_dev);
> > + st->range = range;
> >
> > - return ret;
> > + return 0;
> > + }
> > + unreachable();
> > }
>
> I do agree this is irritating. Personally I would prefer to return 0 (or the
> last ret value) instead of the unusual unreachable() builtin. But that's me :)
Definitely would be an error, not 0 or ret, but I'm still in two minds about this
in general. I think I'll go with unreachable for now and see if we get an
push back.
>
>
> - Nuno Sá
next prev parent reply other threads:[~2024-02-04 13:48 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-28 15:05 [PATCH 00/10] IIO: Use the new cleanup.h magic Jonathan Cameron
2024-01-28 15:05 ` [PATCH 01/10] iio: locking: introduce __cleanup() based direct mode claiming infrastructure Jonathan Cameron
2024-02-04 16:26 ` andy.shevchenko
2024-02-04 17:42 ` Jonathan Cameron
2024-01-28 15:05 ` [PATCH 02/10] iio: dummy: Use automatic lock and direct mode cleanup Jonathan Cameron
2024-01-28 21:52 ` David Lechner
2024-01-29 11:46 ` Jonathan Cameron
2024-01-29 19:58 ` Jonathan Cameron
2024-01-29 20:05 ` David Lechner
2024-02-04 16:29 ` andy.shevchenko
2024-02-04 17:41 ` Jonathan Cameron
2024-01-28 15:05 ` [PATCH 03/10] iio: accel: adxl367: Use automated cleanup for locks and iio direct mode Jonathan Cameron
2024-01-30 12:53 ` Nuno Sá
2024-02-04 13:48 ` Jonathan Cameron [this message]
2024-02-05 8:27 ` Nuno Sá
2024-01-28 15:05 ` [PATCH 04/10] iio: imu: bmi323: Use cleanup handling for iio_device_claim_direct_mode() Jonathan Cameron
2024-01-28 15:05 ` [PATCH 05/10] iio: adc: max1363: Use automatic cleanup for locks and iio mode claiming Jonathan Cameron
2024-01-28 15:05 ` [PATCH 06/10] iio: proximity: sx9360: Use automated cleanup for locks and IIO " Jonathan Cameron
2024-01-28 15:05 ` [PATCH 07/10] iio: proximity: sx9324: " Jonathan Cameron
2024-01-28 15:05 ` [PATCH 08/10] iio: proximity: sx9310: " Jonathan Cameron
2024-01-28 15:05 ` [PATCH 09/10] iio: adc: ad4130: Use automatic cleanup of locks and direct mode Jonathan Cameron
2024-01-28 15:05 ` [PATCH 10/10] iio: adc: ad7091r-base: Use auto cleanup of locks Jonathan Cameron
2024-01-30 14:08 ` [PATCH 00/10] IIO: Use the new cleanup.h magic Nuno Sá
2024-02-04 16:06 ` Jonathan Cameron
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240204134817.1a2dff4f@jic23-huawei \
--to=jic23@kernel.org \
--cc=Jonathan.Cameron@huawei.com \
--cc=dlechner@baylibre.com \
--cc=linux-iio@vger.kernel.org \
--cc=noname.nuno@gmail.com \
--cc=peterz@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox