Linux IIO development
 help / color / mirror / Atom feed
From: Jonathan Cameron <jic23@kernel.org>
To: Mario Limonciello <mario.limonciello@amd.com>
Cc: Lars-Peter Clausen <lars@metafoo.de>,
	"open list:IIO SUBSYSTEM AND DRIVERS" <linux-iio@vger.kernel.org>,
	open list <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] iio: accel: Fix a compilation problem
Date: Sun, 4 Feb 2024 15:16:05 +0000	[thread overview]
Message-ID: <20240204151605.237eb2a4@jic23-huawei> (raw)
In-Reply-To: <20240131225246.14169-1-mario.limonciello@amd.com>

On Wed, 31 Jan 2024 16:52:46 -0600
Mario Limonciello <mario.limonciello@amd.com> wrote:

> The kernel fails when compiling without `CONFIG_REGMAP_I2C` but with
> `CONFIG_BMA400`.
> ```
> ld: drivers/iio/accel/bma400_i2c.o: in function `bma400_i2c_probe':
> bma400_i2c.c:(.text+0x23): undefined reference to `__devm_regmap_init_i2c'
> ```
> 
> This was caught with one of the kconfigs used by the LKP robot for a
> separate issue.
> 
> Link: https://download.01.org/0day-ci/archive/20240131/202401311634.FE5CBVwe-lkp@intel.com/config
> Signed-off-by: Mario Limonciello <mario.limonciello@amd.com>

Good catch.  Ideally would have a fixes tag but it's a bit complex in this
case as they two parts landed in different series.
I've added both tags and marked it for stable.

Fixes: 465c811f1f20 ("iio: accel: Add driver for the BMA400")
Fixes: 9bea10642396 ("iio: accel: bma400: add support for bma400 spi")

> ---
>  drivers/iio/accel/Kconfig | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/drivers/iio/accel/Kconfig b/drivers/iio/accel/Kconfig
> index 91adcac875a4..c9d7afe489e8 100644
> --- a/drivers/iio/accel/Kconfig
> +++ b/drivers/iio/accel/Kconfig
> @@ -219,10 +219,12 @@ config BMA400
>  
>  config BMA400_I2C
>  	tristate
> +	select REGMAP_I2C
>  	depends on BMA400
>  
>  config BMA400_SPI
>  	tristate
> +	select REGMAP_SPI
>  	depends on BMA400
>  
>  config BMC150_ACCEL


      reply	other threads:[~2024-02-04 15:16 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-01-31 22:52 [PATCH] iio: accel: Fix a compilation problem Mario Limonciello
2024-02-04 15:16 ` Jonathan Cameron [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240204151605.237eb2a4@jic23-huawei \
    --to=jic23@kernel.org \
    --cc=lars@metafoo.de \
    --cc=linux-iio@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mario.limonciello@amd.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox