Re: [PATCH v5 0/2] Add bmi323 support for ASUS ROG ALLY

[Jonathan Cameron <jic23@kernel.org>]

On Thu, 15 Feb 2024 10:19:52 -0800
J Lo <jlobue10@gmail.com> wrote:

> From: Jonathan LoBue <jlobue10@gmail.com>

Hi Jonathan

Cover letter should always include at least a short overview of what
the patch is doing.

Long term this solution may be a pain to maintain.
The reasoning is the DT path where we have moved over time to allow
for fallback compatibles (same concept exists in ACPI even if it is
little used) to be used even if we don't recognise a ID read from
the chip.  The intent being to allow old kernels to work with new
devices where they really are backwards compatible.

If that gets fixed in these drivers, we will have to explicitly
exclude ACPI IDs.

Hopefully we'll pick up such issues in review though so this should be fine.

I'd like input from Hans though on whether this solution of duplicating
the IDs generally works out longer term and is appropriate here.

Jonathan


> 
> Changes since v4:
> - Fixed comment location in bmc150.
> - Fixed signed off by portion.
> 
> Jonathan LoBue (2):
>   iio: accel: bmc150: Duplicate ACPI entries
>   iio: imu: bmi323: Add and enable ACPI Match Table
> 
>  drivers/iio/accel/bmc150-accel-i2c.c | 13 +++++++++++++
>  drivers/iio/imu/bmi323/bmi323_i2c.c  | 20 ++++++++++++++++++++
>  2 files changed, 33 insertions(+)
> --
> 2.43.0