From: Jonathan Cameron <jic23@kernel.org>
To: Dimitri Fedrau <dima.fedrau@gmail.com>
Cc: Lars-Peter Clausen <lars@metafoo.de>, Li peiyu <579lpy@gmail.com>,
Nuno Sa <nuno.sa@analog.com>,
Javier Carrasco <javier.carrasco.cruz@gmail.com>,
linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v4 0/3] iio: humidity: hdc3020: add threshold events support
Date: Fri, 16 Feb 2024 13:17:21 +0000 [thread overview]
Message-ID: <20240216131721.745f039e@jic23-huawei> (raw)
In-Reply-To: <20240214085350.19382-1-dima.fedrau@gmail.com>
On Wed, 14 Feb 2024 09:53:42 +0100
Dimitri Fedrau <dima.fedrau@gmail.com> wrote:
> Based on Fix:
> a69eeaad093d "iio: humidity: hdc3020: fix temperature offset" in branch
> fixes-togreg
This applies fine independent of that (they will meet each other upstream!)
so I'll take this via my tree now rather than waiting to get that dependency
after a pull request / rebase. It will also actually get built in next
where the missing Kconfig / Makefile fix is in place.
Applied to the togreg branch of iio.git. Normally I'd push it out as testing but
given I haven't yet queued anything up today and this won't get built
until it hits next I've pushed it out as togreg directly after a quick local
build test.
Thanks,
Jonathan
>
> Changes in V2:
> - Fix alphabetical order of includes(Christophe)
> - Fix typo: change varibale name "HDC3020_R_R_RH_THRESH_LOW_CLR" to
> HDC3020_R_T_RH_THRESH_LOW_CLR to match variable name pattern(Christophe)
> - Add constants HDC3020_MIN_TEMP and HDC3020_MAX_TEMP for min/max threshold
> inputs (Christophe)
> - Change HDC3020_MIN_TEMP to -40, as stated in the datasheet(Javier)
>
> Changes in V3:
> - drop u8 register pairs and switch to 16bit defines(Jonathan)
> - create helper functions to avoid code duplication(Jonathan)
> - Add interrupt bindings in example
> - use the decimal part for setting thresholds(Javier)
> - use return in switch cases hdc3020_read_thresh(Jonathan)
> - fix interrupt handler:(Jonathan)
> - return IRQ_HANDLED when we get a read back failure
> - take the timestamp into a local variable
> - fix multiline comments(Jonathan)
> - use fixed value "hdc3020" instead of dev_id in probe
> - clear interrupt after registering the interrupt handler
> - remove interrupt polarity
>
> Changes in V4:
> - fix commit message of patch "iio: humidity: hdc3020: switch to 16bit
> register defines". (Jonathan)
> - add missing include in bindings example. (Javier, Rob)
> - added copyright information
>
> Dimitri Fedrau (3):
> iio: humidity: hdc3020: switch to 16bit register defines
> dt-bindings: iio: humidity: hdc3020: add interrupt bindings in example
> iio: humidity: hdc3020: add threshold events support
>
> .../bindings/iio/humidity/ti,hdc3020.yaml | 3 +
> drivers/iio/humidity/hdc3020.c | 445 ++++++++++++------
> 2 files changed, 312 insertions(+), 136 deletions(-)
>
next prev parent reply other threads:[~2024-02-16 13:17 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-14 8:53 [PATCH v4 0/3] iio: humidity: hdc3020: add threshold events support Dimitri Fedrau
2024-02-14 8:53 ` [PATCH v4 1/3] iio: humidity: hdc3020: switch to 16bit register defines Dimitri Fedrau
2024-02-14 8:53 ` [PATCH v4 2/3] dt-bindings: iio: humidity: hdc3020: add interrupt bindings in example Dimitri Fedrau
2024-02-15 15:14 ` Rob Herring
2024-02-14 8:53 ` [PATCH v4 3/3] iio: humidity: hdc3020: add threshold events support Dimitri Fedrau
2024-02-14 23:18 ` Javier Carrasco
2024-02-16 20:35 ` Dimitri Fedrau
2024-02-16 13:17 ` Jonathan Cameron [this message]
2024-02-16 20:38 ` [PATCH v4 0/3] " Dimitri Fedrau
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240216131721.745f039e@jic23-huawei \
--to=jic23@kernel.org \
--cc=579lpy@gmail.com \
--cc=dima.fedrau@gmail.com \
--cc=javier.carrasco.cruz@gmail.com \
--cc=lars@metafoo.de \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nuno.sa@analog.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox