From: Jonathan Cameron <jic23@kernel.org>
To: Matti Vaittinen <mazziesaccount@gmail.com>
Cc: Subhajit Ghosh <subhajit.ghosh@tweaklogic.com>,
Matti Vaittinen <matti.vaittinen@fi.rohmeurope.com>,
Lars-Peter Clausen <lars@metafoo.de>,
linux-kernel@vger.kernel.org,
David Laight <David.Laight@aculab.com>,
linux-iio@vger.kernel.org
Subject: Re: [RESEND PATCH v2] iio: gts-helper: Fix division loop
Date: Mon, 19 Feb 2024 19:32:54 +0000 [thread overview]
Message-ID: <20240219193254.2800e00f@jic23-huawei> (raw)
In-Reply-To: <f1511679-0309-4aa6-bbfe-40d0d3374634@gmail.com>
On Mon, 19 Feb 2024 09:22:24 +0200
Matti Vaittinen <mazziesaccount@gmail.com> wrote:
> On 2/18/24 07:26, Subhajit Ghosh wrote:
> > On 18/2/24 02:57, Jonathan Cameron wrote:
> >> On Sun, 18 Feb 2024 01:09:33 +1030
> >> Subhajit Ghosh <subhajit.ghosh@tweaklogic.com> wrote:
> >>
> >>> On 17/2/24 00:28, Jonathan Cameron wrote:
> >>>> On Mon, 12 Feb 2024 13:20:09 +0200
> >>>> Matti Vaittinen <mazziesaccount@gmail.com> wrote:
> >>>>> The loop based 64bit division may run for a long time when dividend
> >>>>> is a
> >>>>> lot bigger than the divider. Replace the division loop by the
> >>>>> div64_u64() which implementation may be significantly faster.
> >>>>>
> >>>>> Signed-off-by: Matti Vaittinen <mazziesaccount@gmail.com>
> >>>>> Fixes: 38416c28e168 ("iio: light: Add gain-time-scale helpers")
> >>>>>
> >>>>> ---
>
>
> > As I understand that you have already applied this patch but still,
> >
> > Tested-by: Subhajit Ghosh <subhajit.ghosh@tweaklogic.com>
>
> Thank you Subhajit! Your effort is _very much_ appreciated! :)
I had to rebase the tree anyway to squash an unrelated issue, so
I added the tag whilst doing so.
Thanks,
Jonathan
>
> Yours,
> -- Matti
>
next prev parent reply other threads:[~2024-02-19 19:33 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-12 11:20 [RESEND PATCH v2] iio: gts-helper: Fix division loop Matti Vaittinen
2024-02-16 13:58 ` Jonathan Cameron
2024-02-17 14:39 ` Subhajit Ghosh
2024-02-17 16:27 ` Jonathan Cameron
2024-02-18 5:26 ` Subhajit Ghosh
2024-02-19 7:22 ` Matti Vaittinen
2024-02-19 19:32 ` Jonathan Cameron [this message]
2024-02-24 0:11 ` Subhajit Ghosh
2024-02-19 7:18 ` Matti Vaittinen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240219193254.2800e00f@jic23-huawei \
--to=jic23@kernel.org \
--cc=David.Laight@aculab.com \
--cc=lars@metafoo.de \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=matti.vaittinen@fi.rohmeurope.com \
--cc=mazziesaccount@gmail.com \
--cc=subhajit.ghosh@tweaklogic.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox