From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from metis.whiteo.stw.pengutronix.de (metis.whiteo.stw.pengutronix.de [185.203.201.7]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E42728005E for ; Mon, 26 Feb 2024 12:56:46 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=185.203.201.7 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1708952209; cv=none; b=nyvLsB0QV2/gWJJfbSFPd1uz9T8KIrBByWuZNODnNIRUm6dS7IUuZDkfZySVPkiaDFgntcvSf8yzcXTK/MU/gNtHZYZjCT2SxptKxXXeVvNglNe/gqNNnF9Ce4Qudaa7nKKEseuCpgZyCuif1aq7x8KvGiE/9UFLcsgT/EZM2fM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1708952209; c=relaxed/simple; bh=v2fHPjr+AJGeygPno3pZb25Xa2vnISkDytCFdLMvFDo=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=S4pY8i5Zz2/segeXYOtlxvDVW8W/NmFGOnEmqjaI19MpsBVw3TLTDcbac8mKkMVtD/p3tWiMpkOXw8Uji71h64fjVsJH6m1o/ZT7ugK2j/LxYJFPsgM7lOqlVxL9jYY6KSOkoU/5No/+dk4SpAWYdLKjtwwofKnZui89/H1h0w4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=pengutronix.de; spf=pass smtp.mailfrom=pengutronix.de; arc=none smtp.client-ip=185.203.201.7 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=pengutronix.de Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=pengutronix.de Received: from drehscheibe.grey.stw.pengutronix.de ([2a0a:edc0:0:c01:1d::a2]) by metis.whiteo.stw.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1reaX7-00017f-Pc; Mon, 26 Feb 2024 13:56:37 +0100 Received: from [2a0a:edc0:2:b01:1d::c5] (helo=pty.whiteo.stw.pengutronix.de) by drehscheibe.grey.stw.pengutronix.de with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1reaX7-002zvQ-Ap; Mon, 26 Feb 2024 13:56:37 +0100 Received: from mfe by pty.whiteo.stw.pengutronix.de with local (Exim 4.96) (envelope-from ) id 1reaX7-0095mn-0n; Mon, 26 Feb 2024 13:56:37 +0100 Date: Mon, 26 Feb 2024 13:56:37 +0100 From: Marco Felsch To: Krzysztof Kozlowski Cc: puranjay12@gmail.com, jic23@kernel.org, lars@metafoo.de, robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org, conor+dt@kernel.org, linux-iio@vger.kernel.org, devicetree@vger.kernel.org, kernel@pengutronix.de Subject: Re: [PATCH] dt-bindings: iio: ti,tmp117: add optional label binding Message-ID: <20240226125637.qbc5synwnns7sbvm@pengutronix.de> References: <20240223162042.2658620-1-m.felsch@pengutronix.de> <20240226102323.6awrkxrdfq7j3ymj@pengutronix.de> <09f4b87e-8344-4051-aa69-5117f6c5e481@linaro.org> Precedence: bulk X-Mailing-List: linux-iio@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <09f4b87e-8344-4051-aa69-5117f6c5e481@linaro.org> X-SA-Exim-Connect-IP: 2a0a:edc0:0:c01:1d::a2 X-SA-Exim-Mail-From: mfe@pengutronix.de X-SA-Exim-Scanned: No (on metis.whiteo.stw.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-iio@vger.kernel.org On 24-02-26, Krzysztof Kozlowski wrote: > On 26/02/2024 11:23, Marco Felsch wrote: > > On 24-02-26, Krzysztof Kozlowski wrote: > >> On 23/02/2024 17:20, Marco Felsch wrote: > >>> Add the support to provide an optional label like we do for ADC > >>> channels to identify the device more easily. > >>> > >>> Signed-off-by: Marco Felsch > >>> --- > >>> Hi, > >>> > >>> patchset [1] should be applied first to avoid merge conflicts. > >>> > >>> [1] https://lore.kernel.org/all/20240219131114.134607-1-m.felsch@pengutronix.de/#t > >>> > >>> Regards, > >>> Marco > >>> > >>> .../devicetree/bindings/iio/temperature/ti,tmp117.yaml | 4 ++++ > >>> 1 file changed, 4 insertions(+) > >>> > >>> diff --git a/Documentation/devicetree/bindings/iio/temperature/ti,tmp117.yaml b/Documentation/devicetree/bindings/iio/temperature/ti,tmp117.yaml > >>> index 33f2e9c5bd81..f00c1cb89acd 100644 > >>> --- a/Documentation/devicetree/bindings/iio/temperature/ti,tmp117.yaml > >>> +++ b/Documentation/devicetree/bindings/iio/temperature/ti,tmp117.yaml > >>> @@ -27,6 +27,10 @@ properties: > >>> vcc-supply: > >>> description: provide VCC power to the sensor. > >>> > >>> + label: > >>> + $ref: /schemas/types.yaml#/definitions/string > >> > >> Drop ref. Did you take it from any existing binding? > > > > I used Documentation/devicetree/bindings/iio/adc/adc.yaml as reference. > > I'll fix it there. > > Anyway, label comes from iio schema in dtschema, so this should be just > "true". For sure, I was searching for this generic binding but didn't checked the dt-schema repo :/ That beeing said, only a few iio bindings do use the generic binding. Last question, the dt-schema does not have the $ref, is "string" the default for properties if not specified? Regards, Marco > > Best regards, > Krzysztof > >