From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 55E5C13C3D3; Mon, 29 Apr 2024 19:58:43 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1714420723; cv=none; b=imcEWBzdSVIJP99vvOdgEg/EuuFwLNA5lTcQTMb8BdiOqAvNh9lFlsJwGvT9WNr+huai4eW2KuRpqdJHoIkMBHd38IJKFkGI9bRDFym+konNO46UhjmNM1GGkfRwYpsBRd4IciPv1kQEPjtIYF2VX9MhSl89BOH3ysedgKc076c= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1714420723; c=relaxed/simple; bh=FJvmQIwnYA1NbnDbtlcuaDAxLcWJKfCmQ1jIuMLA13E=; h=Date:From:To:Cc:Subject:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=IlVd5HtOAXTTZvoqMhPmKa+0kTMYzHvIVFIHiPv/UUCR5QAIxyV6G9LErfIWg3NFo8MvV4TTUlylu6sYMILqCmoZh0RyXqHbrNB37AhroR6m9ubr/j8NwCR9FBHgyp+a8yDVtP5nMeO0cP4eGV0a+y8L2P8iTQmfW38dlAkCnwo= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=s3eU3oM1; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="s3eU3oM1" Received: by smtp.kernel.org (Postfix) with ESMTPSA id C3F26C113CD; Mon, 29 Apr 2024 19:58:40 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1714420722; bh=FJvmQIwnYA1NbnDbtlcuaDAxLcWJKfCmQ1jIuMLA13E=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=s3eU3oM1QkXwXD4bjZjWdebdBqh+YAh+y6kNKuXcwFeYdzF6ubphSDkHtEIy7869I da8Xut/07eWgM1D/OWqW0DzsNVFCHBm/uloHAXoo297odUnumA3hEC5hFa/NOEsePt CAKTXl+cWH8Rp8hvhst5LbJkwBD5KPdDDbzcZz7xTWO6MxAxVDva+bBFTRpByD5Sjy hjjML/kFThMgthiLScU5A2sR4nEVbKgF3mIhOw7uvjcn72VSEZyDx2t35pc0gUFhVX macpGAarGQhIovNycizSug07OBs8o+A8Bv7wDLjvX4+Os+fRiaNn8bv4GdjgR23Hcb YpnnlIjIhWf0Q== Date: Mon, 29 Apr 2024 20:58:31 +0100 From: Jonathan Cameron To: Nuno =?UTF-8?B?U8Oh?= Cc: ogustavo@usp.br, lars@metafoo.de, Michael.Hennerich@analog.com, linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 0/3] iio: adc: ad799x: Fix warning generated by checkpatch Message-ID: <20240429205831.662da28a@jic23-huawei> In-Reply-To: <3f8880a7c7bf6be0458ce2ec2deedeb505c4427f.camel@gmail.com> References: <20240428194326.2836387-1-ogustavo@usp.br> <3f8880a7c7bf6be0458ce2ec2deedeb505c4427f.camel@gmail.com> X-Mailer: Claws Mail 4.2.0 (GTK 3.24.41; x86_64-pc-linux-gnu) Precedence: bulk X-Mailing-List: linux-iio@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On Mon, 29 Apr 2024 09:28:25 +0200 Nuno S=C3=A1 wrote: > On Sun, 2024-04-28 at 16:43 -0300, ogustavo@usp.br wrote: > > From: Gustavo Rodrigues > >=20 > > Clean code of iio:adc:ad799x to cease warning messages pointed by > > checkpatch. These include proper variable declaration 'unsigned' to=20 > > 'unsigned int', add blank line and use of octal permission instead of=20 > > symbolic. > >=20 > > Gustavo (3): > > =C2=A0 iio: adc: ad799x: change 'unsigned' to 'unsigned int' declaration > > =C2=A0 iio: adc: ad799x.c: add blank line to avoid warning messages > > =C2=A0 iio: adc: ad799x: Prefer to use octal permission instead of symb= olic > >=20 > > =C2=A0drivers/iio/adc/ad799x.c | 7 ++++--- > > =C2=A01 file changed, 4 insertions(+), 3 deletions(-) > > =20 >=20 > Patches look good. Just one note... It seems Marcelo gave some feedback o= n a > previous iterations so it looks like this should have been marked as v2? >=20 > Anyways, >=20 > Reviewed-by: Nuno Sa >=20 Indeed on v2. Anyhow, applied to the togreg branch of iio.git and pushed out as testing for the autobuilders to see if we missed anything, Thanks, Jonathan