From: Jorge Harrisonn <jorge.harrisonn@usp.br>
To: jic23@kernel.org, lars@metafoo.de
Cc: Jorge Harrisonn <jorge.harrisonn@usp.br>,
linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org,
laisnuto@usp.br
Subject: [PATCH 2/2] iio: adc: ad7923: using claim_direct_scoped for code simplification
Date: Wed, 1 May 2024 18:57:24 -0300 [thread overview]
Message-ID: <20240501215724.26655-3-jorge.harrisonn@usp.br> (raw)
In-Reply-To: <20240501215724.26655-1-jorge.harrisonn@usp.br>
Using iio_device_claim_direct_scoped instead of calling `iio_device
_claim_direct_modeand later callingiio_device_release_direct_mode`
This should make code cleaner and error handling easier
Co-authored-by: Lais Nuto <laisnuto@usp.br>
Signed-off-by: Lais Nuto <laisnuto@usp.br>
Signed-off-by: Jorge Harrisonn <jorge.harrisonn@usp.br>
---
drivers/iio/adc/ad7923.c | 30 ++++++++++++++----------------
1 file changed, 14 insertions(+), 16 deletions(-)
diff --git a/drivers/iio/adc/ad7923.c b/drivers/iio/adc/ad7923.c
index 9d6bf6d0927a..a646521b2ef3 100644
--- a/drivers/iio/adc/ad7923.c
+++ b/drivers/iio/adc/ad7923.c
@@ -260,22 +260,20 @@ static int ad7923_read_raw(struct iio_dev *indio_dev,
switch (m) {
case IIO_CHAN_INFO_RAW:
- ret = iio_device_claim_direct_mode(indio_dev);
- if (ret)
- return ret;
- ret = ad7923_scan_direct(st, chan->address);
- iio_device_release_direct_mode(indio_dev);
-
- if (ret < 0)
- return ret;
-
- if (chan->address == EXTRACT(ret, 12, 4))
- *val = EXTRACT(ret, chan->scan_type.shift,
- chan->scan_type.realbits);
- else
- return -EIO;
-
- return IIO_VAL_INT;
+ iio_device_claim_direct_scoped(return -EBUSY, indio_dev) {
+ ret = ad7923_scan_direct(st, chan->address);
+
+ if (ret < 0)
+ return ret;
+
+ if (chan->address == EXTRACT(ret, 12, 4))
+ *val = EXTRACT(ret, 0, 12);
+ else
+ return -EIO;
+
+ return IIO_VAL_INT;
+ }
+ unreachable();
case IIO_CHAN_INFO_SCALE:
ret = ad7923_get_range(st);
if (ret < 0)
--
2.34.1
next prev parent reply other threads:[~2024-05-01 21:57 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-01 21:57 [PATCH 0/2] Use of `claim_direct_scoped` for improved error handling Jorge Harrisonn
2024-05-01 21:57 ` [PATCH 1/2] iio: adc: ad7606: using claim_direct_scoped for code simplification Jorge Harrisonn
2024-05-04 11:34 ` Jonathan Cameron
2024-05-04 16:08 ` Markus Elfring
2024-05-01 21:57 ` Jorge Harrisonn [this message]
2024-05-04 11:38 ` [PATCH 2/2] iio: adc: ad7923: " Jonathan Cameron
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240501215724.26655-3-jorge.harrisonn@usp.br \
--to=jorge.harrisonn@usp.br \
--cc=jic23@kernel.org \
--cc=laisnuto@usp.br \
--cc=lars@metafoo.de \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox