Linux IIO development
 help / color / mirror / Atom feed
From: Vasileios Amoiridis <vassilisamir@gmail.com>
To: jic23@kernel.org
Cc: ajarizzo@gmail.com, ang.iglesiasg@gmail.com, lars@metafoo.de,
	linux-iio@vger.kernel.org,
	Vasileios Amoiridis <vassilisamir@gmail.com>
Subject: Replying to: [PATCH] iio: pressure: bmp280: Fix BMP580 temperature reading
Date: Thu,  2 May 2024 15:05:15 +0200	[thread overview]
Message-ID: <20240502130515.140852-1-vassilisamir@gmail.com> (raw)
In-Reply-To: <20240428144015.4f0e6681@jic23-huawei>

Hi guys!

I am sending this e-mail as a reply to [1]

I know I am not included in the mailing list, but since I am working on that
driver currently [2] and I am also reading daily the iio mailing list I found
your patch quite interesting and I wanted to test it.

I managed to generate a negative temperature for the sensor and as it looks like
you are right. Before your patch, the return value was overflowing for negative
temperatures. So, good job!

I have one question though:

1) The comment that includes the "milli Celsius" is also similar in the
bmp380_read_temp() function so maybe you could change both. But since it is
a fixes patch, is that necessary to be done in this commit?

[1]: https://lore.kernel.org/linux-iio/Zin2udkXRD0+GrML@adam-asahi.lan/
[2]: https://lore.kernel.org/linux-iio/20240429190046.24252-1-vassilisamir@gmail.com/

P.S: I don't know how tags work, but if for the tested tag the testing that I
did is enough, then here is my tag:

Tested-By: Vasileios Amoiridis <vassilisamir@gmail.com>

  reply	other threads:[~2024-05-02 13:05 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-04-25  6:22 [PATCH] iio: pressure: bmp280: Fix BMP580 temperature reading Adam Rizkalla
2024-04-28 13:40 ` Jonathan Cameron
2024-05-02 13:05   ` Vasileios Amoiridis [this message]
2024-05-02 15:44 ` Angel Iglesias
2024-05-02 17:16   ` Replying to: [PATCH] iio " Vasileios Amoiridis
2024-05-02 18:15     ` Adam Rizkalla
2024-05-03  7:13       ` Angel Iglesias
2024-05-05 18:02         ` Jonathan Cameron

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240502130515.140852-1-vassilisamir@gmail.com \
    --to=vassilisamir@gmail.com \
    --cc=ajarizzo@gmail.com \
    --cc=ang.iglesiasg@gmail.com \
    --cc=jic23@kernel.org \
    --cc=lars@metafoo.de \
    --cc=linux-iio@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox