Linux IIO development
 help / color / mirror / Atom feed
From: "Barnabás Czémán" <trabarni@gmail.com>
To: Jonathan Cameron <jic23@kernel.org>,
	 Lars-Peter Clausen <lars@metafoo.de>
Cc: linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org,
	"Barnabás Czémán" <trabarni@gmail.com>
Subject: [PATCH 1/3] iio: light: stk3310: relax failure to match id
Date: Tue, 21 May 2024 17:34:51 +0200	[thread overview]
Message-ID: <20240521-stk3311-v1-1-07a4966b355a@gmail.com> (raw)
In-Reply-To: <20240521-stk3311-v1-0-07a4966b355a@gmail.com>

Relax failure to match ID to a warning rather than probe fail.
This add abilty to use other compatible variants when chip id
is not defined in the driver.

Signed-off-by: Barnabás Czémán <trabarni@gmail.com>
---
 drivers/iio/light/stk3310.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/drivers/iio/light/stk3310.c b/drivers/iio/light/stk3310.c
index 08d471438175..7cae261541c6 100644
--- a/drivers/iio/light/stk3310.c
+++ b/drivers/iio/light/stk3310.c
@@ -477,8 +477,7 @@ static int stk3310_init(struct iio_dev *indio_dev)
 	    chipid != STK3311_CHIP_ID_VAL &&
 	    chipid != STK3311X_CHIP_ID_VAL &&
 	    chipid != STK3335_CHIP_ID_VAL) {
-		dev_err(&client->dev, "invalid chip id: 0x%x\n", chipid);
-		return -ENODEV;
+		dev_warn(&client->dev, "unknown chip id: 0x%x\n", chipid);
 	}
 
 	state = STK3310_STATE_EN_ALS | STK3310_STATE_EN_PS;

-- 
2.45.1


  reply	other threads:[~2024-05-21 15:34 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-05-21 15:34 [PATCH 0/3] Add support for more stk3311 variant Barnabás Czémán
2024-05-21 15:34 ` Barnabás Czémán [this message]
2024-05-21 15:34 ` [PATCH 2/3] iio: light: stk3310: make chip id check expandable Barnabás Czémán
2024-05-21 15:34 ` [PATCH 3/3] iio: light: stk3310: support more stk3311 variants Barnabás Czémán
2024-05-25 16:50 ` [PATCH 0/3] Add support for more stk3311 variant Jonathan Cameron

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240521-stk3311-v1-1-07a4966b355a@gmail.com \
    --to=trabarni@gmail.com \
    --cc=jic23@kernel.org \
    --cc=lars@metafoo.de \
    --cc=linux-iio@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox