Linux IIO development
 help / color / mirror / Atom feed
From: Vasileios Amoiridis <vassilisamir@gmail.com>
To: Jonathan Cameron <jic23@kernel.org>
Cc: Vasileios Amoiridis <vassilisamir@gmail.com>,
	lars@metafoo.de, andriy.shevchenko@linux.intel.com,
	ang.iglesiasg@gmail.com, mazziesaccount@gmail.com,
	ak@it-klinger.de, petre.rodan@subdimension.ro,
	phil@raspberrypi.com, 579lpy@gmail.com, linus.walleij@linaro.org,
	semen.protsenko@linaro.org, linux-iio@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH v7 5/5] iio: pressure: bmp280: Add triggered buffer support
Date: Thu, 30 May 2024 01:49:17 +0200	[thread overview]
Message-ID: <20240529234917.GA83937@vamoiridPC> (raw)
In-Reply-To: <20240529211228.2d7fbd93@jic23-huawei>

On Wed, May 29, 2024 at 09:12:28PM +0100, Jonathan Cameron wrote:
> On Mon, 13 May 2024 01:05:24 +0200
> Vasileios Amoiridis <vassilisamir@gmail.com> wrote:
> 
> > BMP2xx, BME280, BMP3xx, and BMP5xx use continuous buffers for their
> > temperature, pressure and humidity readings. This facilitates the
> > use of burst/bulk reads in order to acquire data faster. The
> > approach is different from the one used in oneshot captures.
> > 
> > BMP085 & BMP1xx devices use a completely different measurement
> > process that is well defined and is used in their buffer_handler().
> > 
> > Suggested-by: Angel Iglesias <ang.iglesiasg@gmail.com>
> > Signed-off-by: Vasileios Amoiridis <vassilisamir@gmail.com>
> > ---
> 
> > +
> > +const struct iio_buffer_setup_ops bmp280_buffer_setup_ops = {
> 0-day noted that this isn't actually used.
> I'll add it to the buffer setup where it's currently passed as null.

Hi Jonathan,

Yes, 0-day informed me, but I was not sure what to do so I was waiting
to see if you would see it during the weekend. Thanks for taking care
of it.

Cheers,
Vasilis
> > +	.preenable = bmp280_buffer_preenable,
> > +	.postdisable = bmp280_buffer_postdisable,
> > +};
> > +

      reply	other threads:[~2024-05-29 23:49 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-05-12 23:05 [PATCH v7 0/5] iio: pressure: bmp280: Add triggered buffer support and Vasileios Amoiridis
2024-05-12 23:05 ` [PATCH v7 1/5] iio: pressure: bmp280: Refactorize reading functions Vasileios Amoiridis
2024-05-19 14:22   ` Jonathan Cameron
2024-05-12 23:05 ` [PATCH v7 2/5] iio: pressure: bmp280: Introduce new cleanup routines Vasileios Amoiridis
2024-05-19 14:24   ` Jonathan Cameron
2024-05-12 23:05 ` [PATCH v7 3/5] iio: pressure: bmp280: Generalize read_{temp,press,humid}() functions Vasileios Amoiridis
2024-05-19 14:28   ` Jonathan Cameron
2024-05-12 23:05 ` [PATCH v7 4/5] iio: pressure: bmp280: Add SCALE, RAW values in channels and refactorize them Vasileios Amoiridis
2024-05-19 14:30   ` Jonathan Cameron
2024-05-12 23:05 ` [PATCH v7 5/5] iio: pressure: bmp280: Add triggered buffer support Vasileios Amoiridis
2024-05-19 14:35   ` Jonathan Cameron
2024-05-29 20:12   ` Jonathan Cameron
2024-05-29 23:49     ` Vasileios Amoiridis [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240529234917.GA83937@vamoiridPC \
    --to=vassilisamir@gmail.com \
    --cc=579lpy@gmail.com \
    --cc=ak@it-klinger.de \
    --cc=andriy.shevchenko@linux.intel.com \
    --cc=ang.iglesiasg@gmail.com \
    --cc=jic23@kernel.org \
    --cc=lars@metafoo.de \
    --cc=linus.walleij@linaro.org \
    --cc=linux-iio@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mazziesaccount@gmail.com \
    --cc=petre.rodan@subdimension.ro \
    --cc=phil@raspberrypi.com \
    --cc=semen.protsenko@linaro.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox