Linux IIO development
 help / color / mirror / Atom feed
From: Dumitru Ceclan via B4 Relay <devnull+dumitru.ceclan.analog.com@kernel.org>
To: Lars-Peter Clausen <lars@metafoo.de>,
	 Jonathan Cameron <jic23@kernel.org>
Cc: linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org,
	 Dumitru Ceclan <mitrutzceclan@gmail.com>,
	 Dumitru Ceclan <dumitru.ceclan@analog.com>
Subject: [PATCH v3 4/5] iio: adc: ad7173: Clear append status bit
Date: Thu, 30 May 2024 15:07:52 +0300	[thread overview]
Message-ID: <20240530-ad7173-fixes-v3-4-b85f33079e18@analog.com> (raw)
In-Reply-To: <20240530-ad7173-fixes-v3-0-b85f33079e18@analog.com>

From: Dumitru Ceclan <dumitru.ceclan@analog.com>

The previous value of the append status bit was not cleared before
setting the new value. This caused the bit to remain set after enabling
buffered mode for multiple channels and not permit further buffered
reads from a single channel after the fact.

Fixes: 8eb903272f75 ("iio: adc: ad7173: add AD7173 driver")
Signed-off-by: Dumitru Ceclan <dumitru.ceclan@analog.com>
---
 drivers/iio/adc/ad7173.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/iio/adc/ad7173.c b/drivers/iio/adc/ad7173.c
index eb512878c30e..e66a137a76be 100644
--- a/drivers/iio/adc/ad7173.c
+++ b/drivers/iio/adc/ad7173.c
@@ -543,6 +543,7 @@ static int ad7173_append_status(struct ad_sigma_delta *sd, bool append)
 	unsigned int interface_mode = st->interface_mode;
 	int ret;
 
+	interface_mode &= ~AD7173_INTERFACE_DATA_STAT;
 	interface_mode |= AD7173_INTERFACE_DATA_STAT_EN(append);
 	ret = ad_sd_write_reg(&st->sd, AD7173_REG_INTERFACE_MODE, 2, interface_mode);
 	if (ret)

-- 
2.43.0



  parent reply	other threads:[~2024-05-30 12:08 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-05-30 12:07 [PATCH v3 0/5] AD7173 fixes Dumitru Ceclan via B4 Relay
2024-05-30 12:07 ` [PATCH v3 1/5] iio: adc: ad7173: fix buffers enablement for ad7176-2 Dumitru Ceclan via B4 Relay
2024-06-02 12:19   ` Jonathan Cameron
2024-05-30 12:07 ` [PATCH v3 2/5] iio: adc: ad7173: Add ad7173_device_info names Dumitru Ceclan via B4 Relay
2024-05-30 12:07 ` [PATCH v3 3/5] iio: adc: ad7173: Remove index from temp channel Dumitru Ceclan via B4 Relay
2024-05-30 12:07 ` Dumitru Ceclan via B4 Relay [this message]
2024-06-02 12:21   ` [PATCH v3 4/5] iio: adc: ad7173: Clear append status bit Jonathan Cameron
2024-05-30 12:07 ` [PATCH v3 5/5] iio: adc: ad7173: Fix sampling frequency setting Dumitru Ceclan via B4 Relay
2024-06-02 12:22   ` Jonathan Cameron

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240530-ad7173-fixes-v3-4-b85f33079e18@analog.com \
    --to=devnull+dumitru.ceclan.analog.com@kernel.org \
    --cc=dumitru.ceclan@analog.com \
    --cc=jic23@kernel.org \
    --cc=lars@metafoo.de \
    --cc=linux-iio@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mitrutzceclan@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox