From: Antoni Pokusinski <apokusinski01@gmail.com>
To: jic23@kernel.org
Cc: apokusinski01@gmail.com, apokusinski@o2.pl,
linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: [PATCH] iio: humidity: si7020: add heater support
Date: Tue, 4 Jun 2024 01:03:23 +0200 [thread overview]
Message-ID: <20240603230323.135181-1-apokusinski@o2.pl> (raw)
In-Reply-To: <20240601132507.316f9b50@jic23-huawei>
Hello, thanks for the review. I have a one question though:
>> @@ -134,6 +259,10 @@ static int si7020_probe(struct i2c_client *client)
>> indio_dev->channels = si7020_channels;
>> indio_dev->num_channels = ARRAY_SIZE(si7020_channels);
>>
>> + /* Default register values */
>> + data->user_reg = 0x3A;
>Can you build that up from fields with names?
>I don't like a magic value where I have no idea what some of the bits are.
In the datasheet it's said that all the bits that are set by default in
the `user_reg` are "reserved" and have no meaning for now. So perhaps
mentioning this in a simple comment would be sufficient here?
next prev parent reply other threads:[~2024-06-03 23:03 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20240528000858.14459-1-apokusinski@o2.pl>
2024-06-01 12:25 ` [PATCH] iio: humidity: si7020: add heater support Jonathan Cameron
2024-06-03 23:03 ` Antoni Pokusinski [this message]
2024-06-06 19:38 ` Jonathan Cameron
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240603230323.135181-1-apokusinski@o2.pl \
--to=apokusinski01@gmail.com \
--cc=apokusinski@o2.pl \
--cc=jic23@kernel.org \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox