From: Conor Dooley <conor@kernel.org>
To: dumitru.ceclan@analog.com
Cc: Lars-Peter Clausen <lars@metafoo.de>,
Michael Hennerich <Michael.Hennerich@analog.com>,
Jonathan Cameron <jic23@kernel.org>,
Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Conor Dooley <conor+dt@kernel.org>,
David Lechner <dlechner@baylibre.com>,
linux-iio@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org,
Dumitru Ceclan <mitrutzceclan@gmail.com>
Subject: Re: [PATCH v5 2/9] dt-bindings: adc: ad7173: add support for ad411x
Date: Tue, 4 Jun 2024 18:34:34 +0100 [thread overview]
Message-ID: <20240604-darkish-paprika-351ad2f72e96@spud> (raw)
In-Reply-To: <20240603-ad4111-v5-2-9a9c54d9ac78@analog.com>
[-- Attachment #1: Type: text/plain, Size: 1067 bytes --]
On Mon, Jun 03, 2024 at 07:23:00PM +0300, Dumitru Ceclan via B4 Relay wrote:
> + common-mode-channel:
> + description:
> + This property is used for defining the negative input of a
> + single-ended or pseudo-differential voltage channel.
> +
> + Special inputs are valid as well.
> + minimum: 0
> + maximum: 31
I think this property, since it purports to be a common one due to the
lack of a vendor prefix, should be documented in adc.yaml.
> +
> adi,reference-select:
> description: |
> Select the reference source to use when converting on
> @@ -154,9 +213,31 @@ patternProperties:
> - avdd
> default: refout-avss
>
> + adi,current-channel:
> + description: |
> + Signal that the selected inputs are current channels.
> + Only available on AD4111 and AD4112.
> + type: boolean
Instead of boolean, use:
$ref: /schemas/types.yaml#/definitions/flag
Otherwise, I think this all looks okay.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]
next prev parent reply other threads:[~2024-06-04 17:34 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-03 16:22 [PATCH v5 0/9] Add support for AD411x Dumitru Ceclan via B4 Relay
2024-06-03 16:22 ` [PATCH v5 1/9] dt-bindings: iio: adc: Add common-mode-channel property Dumitru Ceclan via B4 Relay
2024-06-04 17:35 ` Conor Dooley
2024-06-03 16:23 ` [PATCH v5 2/9] dt-bindings: adc: ad7173: add support for ad411x Dumitru Ceclan via B4 Relay
2024-06-04 17:34 ` Conor Dooley [this message]
2024-06-04 17:35 ` Conor Dooley
2024-06-03 16:23 ` [PATCH v5 3/9] iio: adc: ad_sigma_delta: add disable_one callback Dumitru Ceclan via B4 Relay
2024-06-03 16:23 ` [PATCH v5 4/9] iio: adc: ad7173: refactor channel configuration parsing Dumitru Ceclan via B4 Relay
2024-06-03 16:23 ` [PATCH v5 5/9] iio: adc: ad7173: refactor ain and vref selection Dumitru Ceclan via B4 Relay
2024-06-03 16:23 ` [PATCH v5 6/9] iio: adc: ad7173: add support for special inputs Dumitru Ceclan via B4 Relay
2024-06-03 16:23 ` [PATCH v5 7/9] iio: adc: ad7173: refactor device info structs Dumitru Ceclan via B4 Relay
2024-06-05 18:40 ` David Lechner
2024-06-03 16:23 ` [PATCH v5 8/9] iio: adc: ad7173: document sampling frequency behaviour Dumitru Ceclan via B4 Relay
2024-06-03 16:23 ` [PATCH v5 9/9] iio: adc: ad7173: Add support for AD411x devices Dumitru Ceclan via B4 Relay
2024-06-05 19:20 ` David Lechner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240604-darkish-paprika-351ad2f72e96@spud \
--to=conor@kernel.org \
--cc=Michael.Hennerich@analog.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dlechner@baylibre.com \
--cc=dumitru.ceclan@analog.com \
--cc=jic23@kernel.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=lars@metafoo.de \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mitrutzceclan@gmail.com \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox