Linux IIO development
 help / color / mirror / Atom feed
From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Lucas Stankus <lucas.p.stankus@gmail.com>,
	 Lars-Peter Clausen <lars@metafoo.de>,
	 Michael Hennerich <Michael.Hennerich@analog.com>,
	 Jonathan Cameron <jic23@kernel.org>,
	Puranjay Mohan <puranjay@kernel.org>,
	 Ramona Bolboaca <ramona.bolboaca@analog.com>,
	 Oleksij Rempel <o.rempel@pengutronix.de>,
	kernel@pengutronix.de,
	 Cosmin Tanislav <cosmin.tanislav@analog.com>,
	 Marius Cristea <marius.cristea@microchip.com>
Cc: linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org,
	 Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Subject: [PATCH 8/8] iio: adc: mcp3564: drop redundant open-coded spi_get_device_match_data()
Date: Thu, 06 Jun 2024 16:26:50 +0200	[thread overview]
Message-ID: <20240606-spi-match-data-v1-8-320b291ee1fe@linaro.org> (raw)
In-Reply-To: <20240606-spi-match-data-v1-0-320b291ee1fe@linaro.org>

The driver calls spi_get_device_match_data() and on its failure calls
again parts of it: spi_get_device_id() and getting driver data.  This is
entirely redundant, because it is part of spi_get_device_match_data().

Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
---
 drivers/iio/adc/mcp3564.c | 6 ------
 1 file changed, 6 deletions(-)

diff --git a/drivers/iio/adc/mcp3564.c b/drivers/iio/adc/mcp3564.c
index e2ae13f1e842..d83bed0e63d2 100644
--- a/drivers/iio/adc/mcp3564.c
+++ b/drivers/iio/adc/mcp3564.c
@@ -1114,7 +1114,6 @@ static int mcp3564_config(struct iio_dev *indio_dev)
 {
 	struct mcp3564_state *adc = iio_priv(indio_dev);
 	struct device *dev = &adc->spi->dev;
-	const struct spi_device_id *dev_id;
 	u8 tmp_reg;
 	u16 tmp_u16;
 	enum mcp3564_ids ids;
@@ -1212,11 +1211,6 @@ static int mcp3564_config(struct iio_dev *indio_dev)
 		 * try using fallback compatible in device tree to deal with some newer part number.
 		 */
 		adc->chip_info = spi_get_device_match_data(adc->spi);
-		if (!adc->chip_info) {
-			dev_id = spi_get_device_id(adc->spi);
-			adc->chip_info = (const struct mcp3564_chip_info *)dev_id->driver_data;
-		}
-
 		adc->have_vref = adc->chip_info->have_vref;
 	} else {
 		adc->chip_info = &mcp3564_chip_infos_tbl[ids];

-- 
2.43.0


  parent reply	other threads:[~2024-06-06 14:27 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-06-06 14:26 [PATCH 0/8] iio: simplify with spi_get_device_match_data() Krzysztof Kozlowski
2024-06-06 14:26 ` [PATCH 1/8] iio: accel: adxl313: " Krzysztof Kozlowski
2024-06-07  8:57   ` Nuno Sá
2024-06-07  9:18     ` Krzysztof Kozlowski
2024-06-08 17:22       ` Jonathan Cameron
2024-06-06 14:26 ` [PATCH 2/8] iio: accel: adxl355: " Krzysztof Kozlowski
2024-06-06 14:26 ` [PATCH 3/8] iio: adc: max11205: " Krzysztof Kozlowski
2024-06-06 14:26 ` [PATCH 4/8] iio: adc: ti-ads131e08: " Krzysztof Kozlowski
2024-06-06 14:26 ` [PATCH 5/8] iio: adc: ti-tsc2046: " Krzysztof Kozlowski
2024-06-06 14:26 ` [PATCH 6/8] iio: addac: ad74413r: " Krzysztof Kozlowski
2024-06-06 14:26 ` [PATCH 7/8] iio: dac: max5522: " Krzysztof Kozlowski
2024-06-06 14:26 ` Krzysztof Kozlowski [this message]
2024-06-07  8:55 ` [PATCH 0/8] iio: " Nuno Sá
2024-06-08 17:25   ` Jonathan Cameron

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240606-spi-match-data-v1-8-320b291ee1fe@linaro.org \
    --to=krzysztof.kozlowski@linaro.org \
    --cc=Michael.Hennerich@analog.com \
    --cc=cosmin.tanislav@analog.com \
    --cc=jic23@kernel.org \
    --cc=kernel@pengutronix.de \
    --cc=lars@metafoo.de \
    --cc=linux-iio@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=lucas.p.stankus@gmail.com \
    --cc=marius.cristea@microchip.com \
    --cc=o.rempel@pengutronix.de \
    --cc=puranjay@kernel.org \
    --cc=ramona.bolboaca@analog.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox