Linux IIO development
 help / color / mirror / Atom feed
From: Jonathan Cameron <jic23@kernel.org>
To: Yasin Lee <yasin.lee.x@outlook.com>
Cc: andy.shevchenko@gmail.com, lars@metafoo.de,
	linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org,
	nuno.a@analog.com, swboyd@chromium.org,
	u.kleine-koenig@pengutronix.de, yasin.lee.x@gmail.com
Subject: Re: [PATCH v4 0/2] iio:proximity:hx9023s: Add TYHX HX9023S sensor driver
Date: Sat, 8 Jun 2024 17:50:55 +0100	[thread overview]
Message-ID: <20240608175055.3d089acb@jic23-huawei> (raw)
In-Reply-To: <SN7PR12MB8101204CE811B8E88A2464CCA4FB2@SN7PR12MB8101.namprd12.prod.outlook.com>

On Fri,  7 Jun 2024 19:41:36 +0800
Yasin Lee <yasin.lee.x@outlook.com> wrote:

> From: Yasin Lee <yasin.lee.x@gmail.com>
> 
> v4:
> - Removed hardware-irrelevant properties from dt-bindings, retaining only channel configuration
>   related `channel-positive` and `channel-negative`. Grouped by channel. 
>   Retained `channel-in-use` as it is hardware-related.
> - Removed redundant register definitions.
> - Reorganized `struct hx9023s_data`, extracting channel-related attributes 
>   into a new `struct hx9023s_ch_data`.
> - Optimized bit operation related code.
> - Replaced `of_` versions with generic firmware parsing functions.
> - Fixed other issues mentioned in the email feedback.
> 
> Link: https://lore.kernel.org/linux-iio/20240602152638.2c674930@jic23-huawei/

Hi Yasin,

Please fix your patch threading if possible. If it's corporate email getting in
the way, take a look at the b4 tool. It has a nice trick of being able to use
a web gateway and that tends to get out of almost all company networks.

Jonathan

> 
> Yasin Lee (2):
>   dt-bindings:iio:proximity: Add hx9023s binding
>   iio:proximity:hx9023s: Add TYHX HX9023S sensor driver
> 
>  .../bindings/iio/proximity/tyhx,hx9023s.yaml  |  103 ++
>  .../devicetree/bindings/vendor-prefixes.yaml  |    2 +
>  drivers/iio/proximity/Kconfig                 |   14 +
>  drivers/iio/proximity/Makefile                |    1 +
>  drivers/iio/proximity/hx9023s.c               | 1162 +++++++++++++++++
>  5 files changed, 1282 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/iio/proximity/tyhx,hx9023s.yaml
>  create mode 100644 drivers/iio/proximity/hx9023s.c
> 


      reply	other threads:[~2024-06-08 16:51 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-06-07 11:41 [PATCH v4 0/2] iio:proximity:hx9023s: Add TYHX HX9023S sensor driver Yasin Lee
2024-06-08 16:50 ` Jonathan Cameron [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240608175055.3d089acb@jic23-huawei \
    --to=jic23@kernel.org \
    --cc=andy.shevchenko@gmail.com \
    --cc=lars@metafoo.de \
    --cc=linux-iio@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=nuno.a@analog.com \
    --cc=swboyd@chromium.org \
    --cc=u.kleine-koenig@pengutronix.de \
    --cc=yasin.lee.x@gmail.com \
    --cc=yasin.lee.x@outlook.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox