Re: [PATCH v4 2/2] dt-bindings: iio: st-sensors: add LIS2DS12 accelerometer

[Jonathan Cameron <jic23@kernel.org>]

On Sat, 15 Jun 2024 09:46:59 +0000
Kaustabh Chakraborty <kauschluss@disroot.org> wrote:

> On 2024-06-11 18:17, Conor Dooley wrote:
> > On Tue, Jun 11, 2024 at 09:35:53PM +0530, Kaustabh Chakraborty wrote:  
> >> Add compatible for LIS2DS12 accelerometer by STMicroelectronics.  
> > 
> > I can see that! Your commit message should mention why this device
> > is not compatible with existing variants.  
> 
> Sure, is adding the WhoAmI value enough? Or do I also have to
> explain the different registers and sensor settings.
> 
Who ami is not enough, but a statement along the lines of
"The register interface is not compatible with existing parts, for
example addresses and contents of numerous registers are different"

With whatever the actual differences are.

> > 
> > Thanks,
> > Conor.
> >   
> >> 
> >> Signed-off-by: Kaustabh Chakraborty <kauschluss@disroot.org>
> >> ---
> >>  Documentation/devicetree/bindings/iio/st,st-sensors.yaml | 1 +
> >>  1 file changed, 1 insertion(+)
> >> 
> >> diff --git a/Documentation/devicetree/bindings/iio/st,st-sensors.yaml b/Documentation/devicetree/bindings/iio/st,st-sensors.yaml
> >> index fff7e3d83a02..71c1ee33a393 100644
> >> --- a/Documentation/devicetree/bindings/iio/st,st-sensors.yaml
> >> +++ b/Documentation/devicetree/bindings/iio/st,st-sensors.yaml
> >> @@ -26,6 +26,7 @@ properties:
> >>            - st,lis2dw12
> >>            - st,lis2hh12
> >>            - st,lis2dh12-accel
> >> +          - st,lis2ds12
> >>            - st,lis302dl
> >>            - st,lis331dl-accel
> >>            - st,lis331dlh-accel
> >> -- 
> >> 2.45.1
> >> 
> >>  
>