Re: [PATCH v2 2/4] dt-bindings: iio: adc: add AD4695 and similar ADCs

Rob Herring
2024-06-24T14:35:26Z

On Tue, Jun 18, 2024 at 07:00:03PM +0100, Conor Dooley wrote:
> On Mon, Jun 17, 2024 at 05:06:29PM -0500, David Lechner wrote:
> > On 6/17/24 4:30 PM, Rob Herring (Arm) wrote:
> > >
> > > On Mon, 17 Jun 2024 14:53:13 -0500, David Lechner wrote:
> > >> Add device tree bindings for AD4695 and similar ADCs.
> > >>
> > >> Signed-off-by: David Lechner <dlechner@baylibre.com>
> > >> ---
> > >>
> > >> v2 changes:
> > >> * Drop *-wlcsp compatible strings
> > >> * Don't use fallback compatible strings
> > >> * Reword supply descriptions
> > >> * Use standard channel properties instead of adi,pin-pairing
> > >> * Fix unnecessary | character
> > >> * Fix missing blank line
> > >> * Add header file with common mode channel macros
> > >> ---
> > >> .../devicetree/bindings/iio/adc/adi,ad4695.yaml | 290 +++++++++++++++++++++
> > >> MAINTAINERS | 10 +
> > >> include/dt-bindings/iio/adi,ad4695.h | 9 +
> > >> 3 files changed, 309 insertions(+)
> > >>
> > >
> > > My bot found errors running 'make dt_binding_check' on your patch:
> > >
> > > yamllint warnings/errors:
> > >
> > > dtschema/dtc warnings/errors:
> > > /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/iio/adc/adi,ad4695.yaml: single-channel: missing type definition
> > > /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/iio/adc/adi,ad4695.yaml: common-mode-channel: missing type definition
> > >
> > > doc reference errors (make refcheckdocs):
> > >
> > > See https://patchwork.ozlabs.org/project/devicetree-bindings/patch/20240617-iio-adc-ad4695-v2-2-63ef6583f25d@baylibre.com
> > >
> > > The base for the series is generally the latest rc1. A different dependency
> > > should be noted in *this* patch.
> > >
> > > If you already ran 'make dt_binding_check' and didn't see the above
> > > error(s), then make sure 'yamllint' is installed and dt-schema is up to
> > > date:
> > >
> > > pip3 install dtschema --upgrade
> > >
> > > Please check and re-submit after running the above command yourself. Note
> > > that DT_SCHEMA_FILES can be set to your schema file to speed up checking
> > > your schema. However, it must be unset to test all examples with your schema.
> > >
> >
> > I think the problem is that I don't have a well-known commit as the
> > base-commit in my cover letter (oversight on my part).
>
> I think for his bot it needs, as written above, to be "in *this* patch".
> I'm not sure if that's to allow for manual review, or something the bot
> does automagically however.

I used to do manual review before sending, but then I added
co-maintainers that review patches before the bot emails got sent out.
So now they are sent out as run without review and dependencies aren't
dealt with at all.

But yes, put something in this patch to say failures are expected
because of a dependency.

Rob