Re: [PATCH V3 1/2] dt-bindings: iio: Add YAML to Awinic proximity sensor

Krzysztof Kozlowski
2024-07-25T13:53:07Z

On 25/07/2024 14:47, wangshuaijie@awinic.com wrote:
>
>>> + $ref: /schemas/types.yaml#/definitions/uint32
>>> + description:
>>> + Set the number of the SAR(Specific Absorption Rate) sensor.
>>> + It is set to 0 if one awinic sar chip is used.
>>> + If two awinic sar chips are used, awinic,sar-label in the first
>>> + awinic-sar should be set to 0 and awinic,sar-label in the second
>>> + awinic-sar should be set to 1.
>>> + In an application where a device utilizes multiple proximity sensors,
>>> + it is used to retrieve the names of the register configuration files
>>> + that the drivers need to load. For example: aw963xx_reg_0.bin/aw963xx_reg_1.bin
>>> +
>>> + awinic,regulator-power-supply:
>>
>> It does not look like you tested the bindings, at least after quick
>> look. Please run `make dt_binding_check` (see
>> Documentation/devicetree/bindings/writing-schema.rst for instructions).
>> Maybe you need to update your dtschema and yamllint.
>>
>
> The patch for v4 will fix these issues.

Really? I commented here that you did not test it, so let's look at v4
and see if you tested it.

Best regards,
Krzysztof