Re: [PATCH V2 05/15] dt-bindings: power: supply: axp20x: Add input-current-limit-microamp

Krzysztof Kozlowski
2024-08-04T15:37:48Z

On 02/08/2024 21:20, Chris Morgan wrote:
> From: Chris Morgan <macromorgan@hotmail.com>
>
> Allow specifying a hard limit of the maximum input current. Some PMICs
> such as the AXP717 can pull up to 3.25A, so allow a value to be
> specified that clamps this in the event the hardware is not designed
> for it.
>
> Signed-off-by: Chris Morgan <macromorgan@hotmail.com>
> ---
> .../power/supply/x-powers,axp20x-usb-power-supply.yaml | 5 +++++
> 1 file changed, 5 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/power/supply/x-powers,axp20x-usb-power-supply.yaml b/Documentation/devicetree/bindings/power/supply/x-powers,axp20x-usb-power-supply.yaml
> index 34b7959d6772..903e0bac24a0 100644
> --- a/Documentation/devicetree/bindings/power/supply/x-powers,axp20x-usb-power-supply.yaml
> +++ b/Documentation/devicetree/bindings/power/supply/x-powers,axp20x-usb-power-supply.yaml
> @@ -31,6 +31,11 @@ properties:
> - const: x-powers,axp803-usb-power-supply
> - const: x-powers,axp813-usb-power-supply
>
> + input-current-limit-microamp:
> + description:
> + Optional value to clamp the maximum input current limit to for
> + the device. The supported min and max values will vary based on
> + the PMIC revision, consult the datasheet for supported values.

If optional, then missing default. Anyway, you miss constraints.

Best regards,
Krzysztof