Re: [PATCH V3 14/15] power: supply: axp20x_battery: add support for AXP717

Chris Morgan
2024-08-20T20:46:33Z

On Tue, Aug 20, 2024 at 01:37:02PM +0800, kernel test robot wrote:
> Hi Chris,
>
> kernel test robot noticed the following build errors:
>
> [auto build test ERROR on sre-power-supply/for-next]
> [also build test ERROR on jic23-iio/togreg lee-mfd/for-mfd-next linus/master v6.11-rc4 next-20240819]
> [cannot apply to lee-mfd/for-mfd-fixes]
> [If your patch is applied to the wrong git tree, kindly drop us a note.
> And when submitting patch, we suggest to use '--base' as documented in
> https://git-scm.com/docs/git-format-patch#_base_tree_information]
>
> url: https://github.com/intel-lab-lkp/linux/commits/Chris-Morgan/iio-adc-axp20x_adc-Add-adc_en1-and-adc_en1-to-axp_data/20240820-005144
> base: https://git.kernel.org/pub/scm/linux/kernel/git/sre/linux-power-supply.git for-next
> patch link: https://lore.kernel.org/r/20240819164619.556309-15-macroalpha82%40gmail.com
> patch subject: [PATCH V3 14/15] power: supply: axp20x_battery: add support for AXP717
> config: arc-randconfig-001-20240820 (https://download.01.org/0day-ci/archive/20240820/202408201232.lgLOd5Nu-lkp@intel.com/config)
> compiler: arceb-elf-gcc (GCC) 13.2.0
> reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20240820/202408201232.lgLOd5Nu-lkp@intel.com/reproduce)
>
> If you fix the issue in a separate patch/commit (i.e. not just a new version of
> the same patch/commit), kindly add following tags
> | Reported-by: kernel test robot <lkp@intel.com>
> | Closes: https://lore.kernel.org/oe-kbuild-all/202408201232.lgLOd5Nu-lkp@intel.com/

Acknowledged. It looks like I need to explicitly include
<linux/bitfield.h>. I'll include that in the next revision.

Thank you,
Chris

>
> All errors (new ones prefixed by >>):
>
> drivers/power/supply/axp20x_battery.c: In function 'axp717_get_constant_charge_current':
> >> drivers/power/supply/axp20x_battery.c:266:16: error: implicit declaration of function 'FIELD_GET' [-Werror=implicit-function-declaration]
> 266 | *val = FIELD_GET(AXP717_ICC_CHARGER_LIM_MASK, *val) *
> | ^~~~~~~~~
> cc1: some warnings being treated as errors
>
>
> vim +/FIELD_GET +266 drivers/power/supply/axp20x_battery.c
>
> 256
> 257 static int axp717_get_constant_charge_current(struct axp20x_batt_ps *axp,
> 258 int *val)
> 259 {
> 260 int ret;
> 261
> 262 ret = regmap_read(axp->regmap, AXP717_ICC_CHG_SET, val);
> 263 if (ret)
> 264 return ret;
> 265
> > 266 *val = FIELD_GET(AXP717_ICC_CHARGER_LIM_MASK, *val) *
> 267 axp->data->ccc_scale;
> 268
> 269 return 0;
> 270 }
> 271
>
> --
> 0-DAY CI Kernel Test Service
> https://github.com/intel/lkp-tests/wiki